You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2009/10/03 00:07:34 UTC

svn commit: r821184 - /incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/XCASSerializer.java

Author: schor
Date: Fri Oct  2 22:07:34 2009
New Revision: 821184

URL: http://svn.apache.org/viewvc?rev=821184&view=rev
Log:
no Jira - fix issue found by findbugs - string concatenation in a loop.

Modified:
    incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/XCASSerializer.java

Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/XCASSerializer.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/XCASSerializer.java?rev=821184&r1=821183&r2=821184&view=diff
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/XCASSerializer.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/XCASSerializer.java Fri Oct  2 22:07:34 2009
@@ -438,11 +438,12 @@
           // xmlStack.addAttribute(INDEXED_ATTR_NAME, TRUE_VALUE);
           addAttribute(workAttrs, INDEXED_ATTR_NAME, Integer.toString(indexRep.get(0)));
         } else {
-          String multIndex = Integer.toString(indexRep.get(0));
+          StringBuilder multIndex = new StringBuilder(); 
+          multIndex.append(Integer.toString(indexRep.get(0)));
           for (int mi = 1; mi < indexRep.size(); mi++) {
-            multIndex += " " + Integer.toString(indexRep.get(mi));
+            multIndex.append(' ').append(Integer.toString(indexRep.get(mi)));
           }
-          addAttribute(workAttrs, INDEXED_ATTR_NAME, multIndex);
+          addAttribute(workAttrs, INDEXED_ATTR_NAME, multIndex.toString());
         }
       }
       // Add ID attribute. We do this for every FS, since otherwise we