[cloudstack] branch 4.13 updated: Fix network rules issue if default egress policy is Allow (#3905)

[da...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.13 by this push:
     new e269b14  Fix network rules issue if default egress policy is Allow (#3905)
e269b14 is described below

commit e269b140950abc41696a464b7e7b216c9e1fe97e
Author: Rakesh <ra...@gmail.com>
AuthorDate: Sun Feb 23 22:12:06 2020 +0100

    Fix network rules issue if default egress policy is Allow (#3905)
---
 .../cloud/network/router/VirtualNetworkApplianceManagerImpl.java    | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
index 43069cb..2fad41e 100644
--- a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
+++ b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@ -1812,10 +1812,8 @@ Configurable, StateListener<VirtualMachine.State, VirtualMachine.Event, VirtualM
         // Fetch firewall Egress rules.
         if (_networkModel.isProviderSupportServiceInNetwork(guestNetworkId, Service.Firewall, provider)) {
             firewallRulesEgress.addAll(_rulesDao.listByNetworkPurposeTrafficType(guestNetworkId, Purpose.Firewall, FirewallRule.TrafficType.Egress));
-            if (firewallRulesEgress.isEmpty()) {
-                //create egress default rule for VR
-                createDefaultEgressFirewallRule(firewallRulesEgress, guestNetworkId);
-            }
+            //create egress default rule for VR
+            createDefaultEgressFirewallRule(firewallRulesEgress, guestNetworkId);
         }
 
         // Re-apply firewall Egress rules