You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Nick Dimiduk (Jira)" <ji...@apache.org> on 2019/11/21 19:27:00 UTC

[jira] [Resolved] (HBASE-23234) Provide .editorconfig based on checkstyle configuration

     [ https://issues.apache.org/jira/browse/HBASE-23234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Dimiduk resolved HBASE-23234.
----------------------------------
    Release Note: Adds a .editorconfig file with configurations populated by IntelliJ, based on our checkstyle configuration. There's lots of IntelliJ-specific configs in here that I assume are not replicated to Eclipse or Netbeans users. Any devs using those tools should push whatever updates they see fit, but please start with the checkstyle configs as the origin of truth.
      Resolution: Fixed

> Provide .editorconfig based on checkstyle configuration
> -------------------------------------------------------
>
>                 Key: HBASE-23234
>                 URL: https://issues.apache.org/jira/browse/HBASE-23234
>             Project: HBase
>          Issue Type: Task
>          Components: build, tooling
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> I don't have an exhaustive analysis of the issue, but there's at least one case where check style plugin configuration disagrees with our settings in {{dev-support/hbase_eclipse_formatter.xml}}.
> Formatter settings produce this code chunk
> {noformat}
>       uncaughtExceptionHandler =
>           (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
> {noformat}
> but check style wants
> {noformat}
>       uncaughtExceptionHandler =
>         (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)