You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/24 08:37:29 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #7249: [AIRFLOW-6626] Add email on failure or retry to default config

kaxil commented on a change in pull request #7249: [AIRFLOW-6626] Add email on failure or retry to default config
URL: https://github.com/apache/airflow/pull/7249#discussion_r370520397
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -299,8 +299,8 @@ def __init__(
         task_id: str,
         owner: str = conf.get('operators', 'DEFAULT_OWNER'),
         email: Optional[Union[str, Iterable[str]]] = None,
-        email_on_retry: bool = True,
-        email_on_failure: bool = True,
+        email_on_retry: bool = conf.getboolean('email', 'default_email_on_retry'),
 
 Review comment:
   Do we want this globally? I think DAG level is fine enough, what is your use-case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services