You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2005/05/02 19:25:03 UTC
Re: svn commit: r165381 - /perl/Apache-Test/branches/test-more-unstable/lib/Apache/Test.pm
stas@apache.org wrote:
> Author: stas
> Date: Fri Apr 29 23:52:59 2005
> New Revision: 165381
>
> URL: http://svn.apache.org/viewcvs?rev=165381&view=rev
> Log:
> drop Test.pm support, require Test::More (a must if we want to support sub-tests
> run by several perl threads, which Test.pm fail to handle since it doesn't maintain
> a proper shared counter)
just FYI but while this was in trunk I noticed that there was a problem -
t/TEST would _not_ exit 1 if the tests failed, making
$ make test && sudo make install
install even if 'make test' failed. after I reverted the change things went
back to normal, so I didn't look into it any deeper.
HTH
--Geoff
Re: svn commit: r165381 - /perl/Apache-Test/branches/test-more-unstable/lib/Apache/Test.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> But it didn't really change anythings, but enforce Test::More. Are you
> sure other tests where you use Test::More don't behave that way?
yes. from trunk:
$ make test TEST_FILES=t/more/02testmore.t; echo $?
...
t/more/02testmore....request has failed (the response code was: 404)
...
make: *** [run_tests] Error 1
2
from test-more-unstable
$ make test TEST_FILES=t/more/02testmore.t; echo $?
...
t/more/02testmore....request has failed (the response code was: 404)
...
0
>
> I've now committed it to the unstable branch, do you still see it that way?
the above test was with a fresh checkout.
--Geoff
Re: svn commit: r165381 - /perl/Apache-Test/branches/test-more-unstable/lib/Apache/Test.pm
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> stas@apache.org wrote:
>
>>Author: stas
>>Date: Fri Apr 29 23:52:59 2005
>>New Revision: 165381
>>
>>URL: http://svn.apache.org/viewcvs?rev=165381&view=rev
>>Log:
>>drop Test.pm support, require Test::More (a must if we want to support sub-tests
>>run by several perl threads, which Test.pm fail to handle since it doesn't maintain
>>a proper shared counter)
>
>
> just FYI but while this was in trunk I noticed that there was a problem -
> t/TEST would _not_ exit 1 if the tests failed, making
>
> $ make test && sudo make install
>
> install even if 'make test' failed. after I reverted the change things went
> back to normal, so I didn't look into it any deeper.
But it didn't really change anythings, but enforce Test::More. Are you
sure other tests where you use Test::More don't behave that way?
I've now committed it to the unstable branch, do you still see it that way?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com