You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:42:56 UTC

[GitHub] [apisix-docker] nic-chen commented on a change in pull request #118: fix: update centos docker to 2.2.

nic-chen commented on a change in pull request #118:
URL: https://github.com/apache/apisix-docker/pull/118#discussion_r556387304



##########
File path: centos/Dockerfile
##########
@@ -1,12 +1,12 @@
 FROM centos:7
 
-ARG APISIX_VERSION=1.2
+ARG APISIX_VERSION=2.2
 LABEL apisix_version="${APISIX_VERSION}"
 
 RUN yum -y install yum-utils\
 	&& yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo \
 	&& yum install -y openresty \
-	&& yum install -y https://github.com/apache/apisix/releases/download/$APISIX_VERSION/apisix-$APISIX_VERSION-0.el7.noarch.rpm \
+	&& yum install -y https://github.com/apache/apisix/releases/download/$APISIX_VERSION/apisix-$APISIX_VERSION-0.x86_64.rpm \

Review comment:
       only 2.2 uses `x86_64`. maybe we should make it compatible with older versions?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org