[GitHub] [iceberg] Fokko commented on a diff in pull request #6372: [Python] Fix incorrect description when set a property

[GitBox <gi...@apache.org>]

Fokko commented on code in PR #6372:
URL: https://github.com/apache/iceberg/pull/6372#discussion_r1042388262


##########
python/pyiceberg/cli/console.py:
##########
@@ -103,7 +103,7 @@ def list(ctx: Context, parent: Optional[str]):  # pylint: disable=redefined-buil
 @click.pass_context
 @catch_exception()
 def describe(ctx: Context, entity: Literal["name", "namespace", "table"], identifier: str):
-    """Describes a namespace xor table"""

Review Comment:
   This is actually a bad joke. If you have hierarchical namespaces, then it will describe the namespace, `namespace.namespace.table`, in the case of a table `namespace.table` it would describe the table. But wouldn't do both (because that's not possible). But I agree that this is better :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org