You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/01/26 08:30:19 UTC

[GitHub] jiangphcn commented on a change in pull request #1126: Hide credential information in replication document for reader

jiangphcn commented on a change in pull request #1126: Hide credential information in replication document for reader
URL: https://github.com/apache/couchdb/pull/1126#discussion_r164054338
 
 

 ##########
 File path: src/couch_replicator/src/couch_replicator_docs.erl
 ##########
 @@ -695,7 +695,8 @@ strip_credentials(Url) when is_binary(Url) ->
         "http\\1://\\2",
         [{return, binary}]);
 strip_credentials({Props}) ->
-    {lists:keydelete(<<"oauth">>, 1, Props)}.
+    Props0 = lists:keydelete(<<"oauth">>, 1, Props),
 
 Review comment:
   Yes, removed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services