[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #431: Custom Infoset validators with SPI

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #431:
URL: https://github.com/apache/incubator-daffodil/pull/431#discussion_r504135758



##########
File path: daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
##########
@@ -71,6 +71,8 @@ private[sapi] object ValidationConversions {
       case ValidationMode.Off => SValidationMode.Off
       case ValidationMode.Limited => SValidationMode.Limited
       case ValidationMode.Full => SValidationMode.Full
+      // todo;; hacking this out for now
+      case _ => SValidationMode.Off

Review comment:
       I've alway sort of viewed ``.api`` as a sort of internal API and ``.sapi`` or ``.japi`` as external publicly usble APIs. For example, right now we only generate java/scala docs for for the daffodil-japi/sapi projects, so anything not in those projects will not be documented. So our sapi/japi sort of wrap things in api.
   
   Maybe this modeToScala thing was a way to get what the internal API though the validation mode was and return it as something an sapi user would understand. But it sounds like we don't actually have getters for the current validation mode, so this is never used?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org