You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Ganeshsivakumar (via GitHub)" <gi...@apache.org> on 2026/04/24 06:48:50 UTC
[PR] [WIP] BatchElements Transfrom for Java SDK [beam]
Ganeshsivakumar opened a new pull request, #38280:
URL: https://github.com/apache/beam/pull/38280
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] BatchElements Transfrom for Java SDK [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38280:
URL: https://github.com/apache/beam/pull/38280#issuecomment-4311237950
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new PTransform called BatchElements to the Apache Beam Java SDK. The purpose of this transform is to facilitate the grouping of elements within a PCollection into lists, enabling efficient batch processing. The implementation includes a mechanism for estimating batch sizes based on performance metrics.
### Highlights
* **New Transform Implementation**: Introduced the BatchElements PTransform to the Java SDK, which is designed to group elements into batches.
* **Batch Size Estimation**: Added a BatchSizeEstimator inner class to track processing time and dynamically determine optimal batch sizes.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] BatchElements Transform for Java SDK [beam]
Posted by "Ganeshsivakumar (via GitHub)" <gi...@apache.org>.
Ganeshsivakumar commented on PR #38280:
URL: https://github.com/apache/beam/pull/38280#issuecomment-4342037940
> but why? There is GroupIntoBatches transform already.
Hi @stankiewicz GroupIntoBatches is per key based and it batch elements per key. Takes an input of [KV.of("key","value")....] and returns [KV.of("key",[batch of values associated with only that key])
BatchElements is a generic batching transform, that will buffer ```Pcol<T>``` and return an ```Pcol<[batch of T]>```, its primarily useful for ML inference like RemoteInference transform where inputs are typically individual elements and we need to batch elements before running inference for efficiency. If we use GroupIntoBatches we'd need to do keying on elements before batching and its an unnecessary step for that usecase. Plus we can dynamically determine batch size at runtime with BatchElements.
This is also a direct java port of python [BatchElements](https://beam.apache.org/documentation/transforms/python/aggregation/batchelements/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] BatchElements Transform for Java SDK [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz closed pull request #38280: [WIP] BatchElements Transform for Java SDK
URL: https://github.com/apache/beam/pull/38280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] BatchElements Transform for Java SDK [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38280:
URL: https://github.com/apache/beam/pull/38280#issuecomment-4342144342
> > but why? There is GroupIntoBatches transform already.
>
> Hi @stankiewicz GroupIntoBatches is per key based and it batch elements per key. Takes an input of [KV.of("key","value")....] and returns [KV.of("key",[batch of values associated with only that key])
>
> BatchElements is a generic batching transform, that will buffer `Pcol<T>` and return an `Pcol<[batch of T]>`, its primarily useful for ML inference like RemoteInference transform where inputs are typically individual elements and we need to batch elements before running inference for efficiency. If we use GroupIntoBatches we'd need to do keying on elements before batching and its an unnecessary step for that usecase. Plus we can dynamically determine batch size at runtime with BatchElements.
>
> This is also a direct java port of python [BatchElements](https://beam.apache.org/documentation/transforms/python/aggregation/batchelements/)
got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] BatchElements Transform for Java SDK [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38280:
URL: https://github.com/apache/beam/pull/38280#issuecomment-4335369702
but why? There is GroupIntoBatches transform already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] BatchElements Transform for Java SDK [beam]
Posted by "ganesh-skumar (via GitHub)" <gi...@apache.org>.
ganesh-skumar commented on PR #38280:
URL: https://github.com/apache/beam/pull/38280#issuecomment-4376261486
Continuing this work under a new account due to access issues with my previous account (@Ganeshsivakumar).
New PR: #38369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org