You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/09/02 22:32:03 UTC
[GitHub] [mynewt-core] benmccrea opened a new pull request #2367: hw/mcu/dialog: Fix size of flag variables when MCU_DMA_CHAN_MAX > 8
benmccrea opened a new pull request #2367:
URL: https://github.com/apache/mynewt-core/pull/2367
These two variables need to be uint16_t when MCU_DMA_CHAN_MAX is > 8.
Currently the code is as follows, which results in not enough bit flags for DMA channel # 9 or higher:
```
#if (MCU_DMA_CHAN_MAX) > 8
static uint8_t g_da1469x_dma_acquired;
static uint8_t g_da1469x_dma_isr_set;
#else
static uint16_t g_da1469x_dma_acquired;
static uint16_t g_da1469x_dma_isr_set;
#endif
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2367: hw/mcu/dialog: Fix size of flag variables when MCU_DMA_CHAN_MAX > 8
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2367:
URL: https://github.com/apache/mynewt-core/pull/2367#issuecomment-686063533
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2367: hw/mcu/dialog: Fix size of flag variables when MCU_DMA_CHAN_MAX > 8
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2367:
URL: https://github.com/apache/mynewt-core/pull/2367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org