You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jonathan Gray <jg...@apache.org> on 2010/10/30 04:42:21 UTC
Review Request: Add TimeRange support into Increment to optimize for
counters that are partitioned on time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1132/
-----------------------------------------------------------
Review request for hbase, stack, Ryan Rawson, and khemani.
Summary
-------
TimeRange now part of Increment. Adds new methods into Increment w/ javadoc. Adds code in our increment operation to set this onto the Gets we use.
This addresses bug HBASE-3162.
http://issues.apache.org/jira/browse/HBASE-3162
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java 1028936
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1028936
Diff: http://review.cloudera.org/r/1132/diff
Testing
-------
increment tests passing.
Thanks,
Jonathan
Re: Review Request: Add TimeRange support into Increment to optimize for
counters that are partitioned on time
Posted by Jonathan Gray <jg...@apache.org>.
> On 2010-10-29 21:19:11, Ryan Rawson wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java, line 274
> > <http://review.cloudera.org/r/1132/diff/1/?file=16260#file16260line274>
> >
> > technically Increment.java has never shipped in a published version of HBase so we wont need to bump any version numbers I think.
+1
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1132/#review1720
-----------------------------------------------------------
On 2010-10-29 19:42:21, Jonathan Gray wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1132/
> -----------------------------------------------------------
>
> (Updated 2010-10-29 19:42:21)
>
>
> Review request for hbase, stack, Ryan Rawson, and khemani.
>
>
> Summary
> -------
>
> TimeRange now part of Increment. Adds new methods into Increment w/ javadoc. Adds code in our increment operation to set this onto the Gets we use.
>
>
> This addresses bug HBASE-3162.
> http://issues.apache.org/jira/browse/HBASE-3162
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java 1028936
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1028936
>
> Diff: http://review.cloudera.org/r/1132/diff
>
>
> Testing
> -------
>
> increment tests passing.
>
>
> Thanks,
>
> Jonathan
>
>
Re: Review Request: Add TimeRange support into Increment to optimize for
counters that are partitioned on time
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1132/#review1720
-----------------------------------------------------------
Ship it!
COMMIT THAT SHIT!
trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java
<http://review.cloudera.org/r/1132/#comment5653>
technically Increment.java has never shipped in a published version of HBase so we wont need to bump any version numbers I think.
- Ryan
On 2010-10-29 19:42:21, Jonathan Gray wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1132/
> -----------------------------------------------------------
>
> (Updated 2010-10-29 19:42:21)
>
>
> Review request for hbase, stack, Ryan Rawson, and khemani.
>
>
> Summary
> -------
>
> TimeRange now part of Increment. Adds new methods into Increment w/ javadoc. Adds code in our increment operation to set this onto the Gets we use.
>
>
> This addresses bug HBASE-3162.
> http://issues.apache.org/jira/browse/HBASE-3162
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java 1028936
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1028936
>
> Diff: http://review.cloudera.org/r/1132/diff
>
>
> Testing
> -------
>
> increment tests passing.
>
>
> Thanks,
>
> Jonathan
>
>
Re: Review Request: Add TimeRange support into Increment to optimize for
counters that are partitioned on time
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1132/#review1716
-----------------------------------------------------------
Ship it!
Looks good to me.
trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java
<http://review.cloudera.org/r/1132/#comment5646>
This a migration problem?
- stack
On 2010-10-29 19:42:21, Jonathan Gray wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1132/
> -----------------------------------------------------------
>
> (Updated 2010-10-29 19:42:21)
>
>
> Review request for hbase, stack, Ryan Rawson, and khemani.
>
>
> Summary
> -------
>
> TimeRange now part of Increment. Adds new methods into Increment w/ javadoc. Adds code in our increment operation to set this onto the Gets we use.
>
>
> This addresses bug HBASE-3162.
> http://issues.apache.org/jira/browse/HBASE-3162
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java 1028936
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1028936
>
> Diff: http://review.cloudera.org/r/1132/diff
>
>
> Testing
> -------
>
> increment tests passing.
>
>
> Thanks,
>
> Jonathan
>
>