You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Andrew Luo <an...@outlook.com> on 2020/02/26 05:41:26 UTC

Review Request 72164: RANGER-2742: Fix database patch 046 on SQL Server and SQL Anywhere

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72164/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2742
    https://issues.apache.org/jira/browse/RANGER-2742


Repository: ranger


Description
-------

On SQL Anywhere the constraint and column names are swapped in some statements.  In SQL Server, the same problem exists in addition to not properly dropping the default constraint.


Diffs
-----

  security-admin/db/sqlanywhere/patches/046-drop-audit-columns-from-policy-ref-tables.sql 10508f6ff 
  security-admin/db/sqlserver/patches/046-drop-audit-columns-from-policy-ref-tables.sql 1af3ec449 


Diff: https://reviews.apache.org/r/72164/diff/1/


Testing
-------

Tested end-to-end on SQL Anywhere and SQL Server, created policies.


Thanks,

Andrew Luo


Re: Review Request 72164: RANGER-2742: Fix database patch 046 on SQL Server and SQL Anywhere

Posted by Andrew Luo <an...@outlook.com>.

> On Feb. 27, 2020, 4:38 a.m., Pradeep Agrawal wrote:
> > Can you consolidate these changes also with RANGER-2713 RR patch ?

Sorry, I already did it: https://reviews.apache.org/r/72166/

I just forgot to close this RR.  Closing now.  Thanks!


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72164/#review219669
-----------------------------------------------------------


On Feb. 26, 2020, 5:41 a.m., Andrew Luo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72164/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2020, 5:41 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2742
>     https://issues.apache.org/jira/browse/RANGER-2742
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> On SQL Anywhere the constraint and column names are swapped in some statements.  In SQL Server, the same problem exists in addition to not properly dropping the default constraint.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/sqlanywhere/patches/046-drop-audit-columns-from-policy-ref-tables.sql 10508f6ff 
>   security-admin/db/sqlserver/patches/046-drop-audit-columns-from-policy-ref-tables.sql 1af3ec449 
> 
> 
> Diff: https://reviews.apache.org/r/72164/diff/1/
> 
> 
> Testing
> -------
> 
> Tested end-to-end on SQL Anywhere and SQL Server, created policies.
> 
> 
> Thanks,
> 
> Andrew Luo
> 
>


Re: Review Request 72164: RANGER-2742: Fix database patch 046 on SQL Server and SQL Anywhere

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72164/#review219669
-----------------------------------------------------------



Can you consolidate these changes also with RANGER-2713 RR patch ?

- Pradeep Agrawal


On Feb. 26, 2020, 5:41 a.m., Andrew Luo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72164/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2020, 5:41 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2742
>     https://issues.apache.org/jira/browse/RANGER-2742
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> On SQL Anywhere the constraint and column names are swapped in some statements.  In SQL Server, the same problem exists in addition to not properly dropping the default constraint.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/sqlanywhere/patches/046-drop-audit-columns-from-policy-ref-tables.sql 10508f6ff 
>   security-admin/db/sqlserver/patches/046-drop-audit-columns-from-policy-ref-tables.sql 1af3ec449 
> 
> 
> Diff: https://reviews.apache.org/r/72164/diff/1/
> 
> 
> Testing
> -------
> 
> Tested end-to-end on SQL Anywhere and SQL Server, created policies.
> 
> 
> Thanks,
> 
> Andrew Luo
> 
>