[jira] [Commented] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

["Taher Alkhateeb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096734#comment-16096734 ] 

Taher Alkhateeb commented on OFBIZ-9447:
----------------------------------------

Nice work Nicolas. I didn't review this patch thoroughly, but at a first glance I think patch 2 seems to provide a better logic (less state).

I note empty generics brackets -> new HashMap<>(); .. probably just a typo?

> Improve groovy DSL : resolve automatic pk field for entity one
> --------------------------------------------------------------
>
>                 Key: OFBIZ-9447
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9447
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: OFBIZ-9447-sol1.patch, OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the pk field from context, I propose like explain on the thread https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)