You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "baumgold (via GitHub)" <gi...@apache.org> on 2023/06/12 14:24:41 UTC
[GitHub] [arrow-julia] baumgold opened a new pull request, #462: cleanup testing
baumgold opened a new pull request, #462:
URL: https://github.com/apache/arrow-julia/pull/462
1. Re-enable commented-out test from #456
2. Use separate test-specific Project.toml to allow for test-specific compat (and remove compat shim)
3. Replace testing println with testsets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj commented on a diff in pull request #462: cleanup testing
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj commented on code in PR #462:
URL: https://github.com/apache/arrow-julia/pull/462#discussion_r1226917703
##########
test/runtests.jl:
##########
@@ -14,18 +14,20 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-using Test, Arrow, ArrowTypes, Tables, Dates, PooledArrays, TimeZones, UUIDs, Sockets,
- CategoricalArrays, DataAPI, FilePathsBase, DataFrames
-using Random: randstring
-
-# Compat shim for pre-julia 1.9
-if !@isdefined(pkgversion)
Review Comment:
Oh nvm, got it. Yeah, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj merged pull request #462: cleanup testing
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj merged PR #462:
URL: https://github.com/apache/arrow-julia/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj commented on a diff in pull request #462: cleanup testing
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj commented on code in PR #462:
URL: https://github.com/apache/arrow-julia/pull/462#discussion_r1226917062
##########
test/runtests.jl:
##########
@@ -14,18 +14,20 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-using Test, Arrow, ArrowTypes, Tables, Dates, PooledArrays, TimeZones, UUIDs, Sockets,
- CategoricalArrays, DataAPI, FilePathsBase, DataFrames
-using Random: randstring
-
-# Compat shim for pre-julia 1.9
-if !@isdefined(pkgversion)
Review Comment:
why don't we need this compat shim anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #462: cleanup testing
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #462:
URL: https://github.com/apache/arrow-julia/pull/462#issuecomment-1587506605
## [Codecov](https://app.codecov.io/gh/apache/arrow-julia/pull/462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#462](https://app.codecov.io/gh/apache/arrow-julia/pull/462?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (94095e8) into [main](https://app.codecov.io/gh/apache/arrow-julia/commit/9f1d51a2c975bd83cbaf70c5f640762c6a0bccaf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9f1d51a) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 26 26
Lines 3272 3272
=======================================
Hits 2864 2864
Misses 408 408
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org