You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/19 03:30:10 UTC
[GitHub] [skywalking-nodejs] tianyk opened a new pull request #54: Add mysql2 plugin
tianyk opened a new pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54
Add [mysql2](https://www.npmjs.com/package/mysql2) plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876077278
There is no 3.0, I don't know what do you mean?
https://www.npmjs.com/package/mysql2 2.2.5 is the latest release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876207761
> version
Still not find the solution, But we can do something in https://github.com/apache/skywalking-nodejs/blob/master/src/core/PluginInstaller.ts#L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876234707
I think you don't understand how to report a potential bug in an open source project and how to help the maintainer to locate it, only providing a error message helps nothing, you don't have a reproducible demo project, nor did you show the Efforts you've made to debug the problem, we are powerless to waste our time to debug this problem as we don't even know whether it's a bug or not because you gave no useful reproducible steps. This plugin is run in our tests with a typical scenario and it passed, if your scenario is different with it you have to provide your scenario in more details, otherwise we are not able to do anything.
We've been asking for more details but you always paste the same error logs, this is a waste of time and useless communication.
> > @riskgod can you print the error in
> > https://github.com/apache/skywalking-nodejs/blob/babf6ebc0022909ef1bb865764045c7ce62c3b1c/src/core/PluginInstaller.ts#L109
> >
> > in your local env to see what's the error?
>
> 'Error installing plugin mysql 2 *'
If you still want to help, try to print the `e`
https://github.com/apache/skywalking-nodejs/blob/babf6ebc0022909ef1bb865764045c7ce62c3b1c/src/core/PluginInstaller.ts#L107-L113
Something like this
```typescript
} catch (e) {
if (plugin) {
logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`, e); // <<===== 👈
} else {
logger.error(`Error processing plugin ${pluginFile}`);
}
}
```
... to see why the plugin is not installed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876076602
> > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
>
> Isn't this a mysql2 plugin?
Yep, our team met this err in the same version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876119044
> > > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0
> >
> >
> > Isn't this a mysql2 plugin?
>
> Yep, our team met this err in the same version.
i want to know how can solve it when you meet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876208947
> > > > > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0
> >
> >
> > > >
> >
> >
> > > >
> >
> >
> > > > Isn't this a mysql2 plugin?
> >
> >
> > >
> >
> >
> > > Yep, our team met this err in the same version.
> >
> >
> > i want to know how can solve it when you meet?
>
> This is open source project, you simply debug directly. I don't know what do you mean.
Yep, try to solve it, but the problem is existed, we need to fix it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874421788
@kezhenxu94 @tianyk when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version skywalking-nodejs 0.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874426125
> @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
Isn't this a mysql2 plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874421788
@kezhenxu94 @tianyk when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version skywalking-nodejs 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 removed a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 removed a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876119044
> > > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0
> >
> >
> > Isn't this a mysql2 plugin?
>
> Yep, our team met this err in the same version.
i want to know how can solve it when you meet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876118689
> There is no 3.0, I don't know what do you mean?
>
> https://www.npmjs.com/package/mysql2 2.2.5 is the latest release.
sorry i mean skywalking-nodejs 0.3.0 version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876118689
> There is no 3.0, I don't know what do you mean?
>
> https://www.npmjs.com/package/mysql2 2.2.5 is the latest release.
sorry i mean skywalking-nodejs version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874421788
@kezhenxu94 @tianyk when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874421788
@kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874421788
@kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874421788
@kezhenxu94 @tianyk when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-874426125
> @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
Isn't this a mysql2 plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876212664
@riskgod can you print the error in https://github.com/apache/skywalking-nodejs/blob/babf6ebc0022909ef1bb865764045c7ce62c3b1c/src/core/PluginInstaller.ts#L109 in your local env to see what's the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-843723260
Test failed. Please recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876255649
> I think you don't understand how to report a potential bug in an open source project and how to help the maintainer to locate it, only providing a error message helps nothing, you don't have a reproducible demo project, nor did you show the Efforts you've made to debug the problem, we are powerless to waste our time to debug this problem as we don't even know whether it's a bug or not because you gave no useful reproducible steps. This plugin is run in our tests with a typical scenario and it passed, if your scenario is different with it you have to provide your scenario in more details, otherwise we are not able to do anything.
>
> We've been asking for more details but you always paste the same error logs, this is a waste of time and useless communication.
>
> > > @riskgod can you print the error in
> > > https://github.com/apache/skywalking-nodejs/blob/babf6ebc0022909ef1bb865764045c7ce62c3b1c/src/core/PluginInstaller.ts#L109
> > >
> > > in your local env to see what's the error?
> >
> >
> > 'Error installing plugin mysql 2 *'
>
> If you still want to help, try to print the `e`
>
> https://github.com/apache/skywalking-nodejs/blob/babf6ebc0022909ef1bb865764045c7ce62c3b1c/src/core/PluginInstaller.ts#L107-L113
>
> Something like this
>
> ```ts
> } catch (e) {
> if (plugin) {
> logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`, e); // <<===== 👈
> } else {
> logger.error(`Error processing plugin ${pluginFile}`);
> }
> }
> ```
>
> ... to see why the plugin is not installed successfully.
yep, found the problem. the mysql2 plugin use exports in package.json. not export commonjs in [here](https://github.com/sidorares/node-mysql2/blob/master/package.json#L46), like this: `".": "./index.cjs"`, still try to fix this is in this npm module. Don't worry, I will try to covert that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876121809
> > > > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0
>
> > >
>
> > >
>
> > > Isn't this a mysql2 plugin?
>
> >
>
> > Yep, our team met this err in the same version.
>
>
>
> i want to know how can solve it when you meet?
This is open source project, you simply debug directly. I don't know what do you mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876207761
> version
Still not found the solution, But we can do something in https://github.com/apache/skywalking-nodejs/blob/master/src/core/PluginInstaller.ts#L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zyfyuanyuan6 commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
zyfyuanyuan6 commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876119044
> > > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0
> >
> >
> > Isn't this a mysql2 plugin?
>
> Yep, our team met this err in the same version.
i want to know how can solve it when you meet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876224126
> @riskgod can you print the error in
>
> https://github.com/apache/skywalking-nodejs/blob/babf6ebc0022909ef1bb865764045c7ce62c3b1c/src/core/PluginInstaller.ts#L109
>
> in your local env to see what's the error?
'Error installing plugin mysql 2 *'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tianyk commented on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
tianyk commented on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-843846609
Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] riskgod edited a comment on pull request #54: Add mysql2 plugin
Posted by GitBox <gi...@apache.org>.
riskgod edited a comment on pull request #54:
URL: https://github.com/apache/skywalking-nodejs/pull/54#issuecomment-876208947
> > > > > @kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0
> >
> >
> > > >
> >
> >
> > > >
> >
> >
> > > > Isn't this a mysql2 plugin?
> >
> >
> > >
> >
> >
> > > Yep, our team met this err in the same version.
> >
> >
> > i want to know how can solve it when you meet?
>
> This is open source project, you simply debug directly. I don't know what do you mean.
Yep, try to solve it, but the problem is existed, we need try to fix it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org