You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/10 06:43:48 UTC

Re: Review Request 37126: Added authorization for dynamic reservation master endpoints.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37126/#review98349
-----------------------------------------------------------



src/tests/reservation_endpoints_tests.cpp (lines 1026 - 1048)
<https://reviews.apache.org/r/37126/#comment154771>

    This part has been refactored to some helper functions, so a refactor is also needed here before merge.


- Guangya Liu


On 八月 5, 2015, 10:46 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37126/
> -----------------------------------------------------------
> 
> (Updated 八月 5, 2015, 10:46 a.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
>   src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db 
>   src/tests/reservation_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37126/diff/
> 
> 
> Testing
> -------
> 
> Added tests to `src/tests/reservation_endpoints_tests.cpp` + `make check`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>