[GitHub] [buildstream-plugins] gtristan commented on a diff in pull request #21: Use build-dir by default

[GitBox <gi...@apache.org>]

gtristan commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933946945


##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
   - |
     %{autogen}
   - |
-    %{configure}
+    if [ -n "%{build-dir}" ]; then
+      mkdir %{build-dir}
+      pushd %{build-dir}
+      %{configure}
+      popd
+    else
+      %{configure}
+    fi
 
   # Commands for building the software
   #
   build-commands:
   - |
-    %{make}
+    if [ -n "%{build-dir}" ]; then
+      pushd %{build-dir}
+      %{make}
+      popd

Review Comment:
   > As far as I've seen bst2 does not.
   
   This is an important detail we have thus far omitted from the [porting guide](https://docs.buildstream.build/master/porting_project.html).
   
   Opening https://github.com/apache/buildstream/issues/1708 to track this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org