[GitHub] [spark] viirya commented on a diff in pull request #42936: [SPARK-45174][CORE] Support `spark.deploy.maxDrivers`

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #42936:
URL: https://github.com/apache/spark/pull/42936#discussion_r1326828633


##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -844,8 +845,8 @@ private[deploy] class Master(
       // We assign workers to each waiting driver in a round-robin fashion. For each driver, we
       // start from the last worker that was assigned a driver, and continue onwards until we have
       // explored all alive workers.
-      var launched = false
-      var isClusterIdle = true
+      var launched = (drivers.size - waitingDrivers.size) >= maxDrivers

Review Comment:
   Hmm, isn't this making submitting driver silently ignored? For example, there is a warning log for the case the driver needs more resources than any worker. Should we also have a warning log for the case that drivers reaches the maximum drivers?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org