[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2168: Implement fast path of with_new_children() in ExecutionPlan

[GitBox <gi...@apache.org>]

yjshen commented on code in PR #2168:
URL: https://github.com/apache/arrow-datafusion/pull/2168#discussion_r844790396


##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -258,6 +258,32 @@ pub trait ExecutionPlan: Debug + Send + Sync {
     fn statistics(&self) -> Statistics;
 }
 
+/// Returns a new plan where all children were replaced by new plans if the provided children
+/// do not share the same point references with the existing children.

Review Comment:
   ```suggestion
   /// Returns a copy of this plan if we change any child according to pointer comparison.
   ///
   ```



##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -258,6 +258,32 @@ pub trait ExecutionPlan: Debug + Send + Sync {
     fn statistics(&self) -> Statistics;
 }
 
+/// Returns a new plan where all children were replaced by new plans if the provided children
+/// do not share the same point references with the existing children.
+/// The size of `children` must be equal to the size of `ExecutionPlan::children()`.
+/// Allow the vtable address comparisons for ExecutionPlan Trait Objects，it is harmless even
+/// in the case of 'false-native'.

Review Comment:
   This should be false-positive I think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org