You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/07/07 22:11:26 UTC
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17659
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
IMPALA-10490: Fix illegalStateException in drop stats
If a table was created and incremental stats were computed on the table
while events processing is turned off, then after the events processing
is turned on a drop stats or truncate table command on such a table
fails with IllegalStateException. This happens because the
catalog service identifiers are not found in the table properties
while partition for the table are being altered. This patch adds
the catalog service identifiers for drop stats, truncate and comment on
statement code paths to fix the error.
Testing:
1. Added more statements to the test_self_events test to cover the
newly added logic.
2. Manually tested the following scenario which was previously failing
a. starting catalogd without events processing.
b. create partitioned table and compute incremental stats on it.
c. restart catalogd with events processing turned on.
d. issue drop stats command.
Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 25 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/17659/1
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
IMPALA-10490: Fix illegalStateException in drop stats
If a table was created and incremental stats were computed on the table
while events processing is turned off, then after the events processing
is turned on a drop stats or truncate table command on such a table
fails with IllegalStateException. This happens because the
catalog service identifiers are not found in the table properties
while partition for the table are being altered. This patch adds
the catalog service identifiers for drop stats, truncate and comment on
statement code paths to fix the error.
Testing:
1. Added more statements to the test_self_events test to cover the
newly added logic.
2. Manually tested the following scenario which was previously failing
a. starting catalogd without events processing.
b. create partitioned table and compute incremental stats on it.
c. restart catalogd with events processing turned on.
d. issue drop stats command.
Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 26 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/17659/4
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17659/2/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:
http://gerrit.cloudera.org:8080/#/c/17659/2/tests/custom_cluster/test_event_processing.py@693
PS2, Line 693: ]
flake8: E123 closing bracket does not match indentation of opening bracket's line
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 18:25:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Jul 2021 23:55:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9091/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 22:34:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9046/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Jul 2021 22:32:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
IMPALA-10490: Fix illegalStateException in drop stats
If a table was created and incremental stats were computed on the table
while events processing is turned off, then after the events processing
is turned on a drop stats or truncate table command on such a table
fails with IllegalStateException. This happens because the
catalog service identifiers are not found in the table properties
while partition for the table are being altered. This patch adds
the catalog service identifiers for drop stats, truncate and comment on
statement code paths to fix the error.
Testing:
1. Added more statements to the test_self_events test to cover the
newly added logic.
2. Manually tested the following scenario which was previously failing
a. starting catalogd without events processing.
b. create partitioned table and compute incremental stats on it.
c. restart catalogd with events processing turned on.
d. issue drop stats command.
Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Reviewed-on: http://gerrit.cloudera.org:8080/17659
Reviewed-by: Vihang Karajgaonkar <vi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 26 insertions(+), 3 deletions(-)
Approvals:
Vihang Karajgaonkar: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
IMPALA-10490: Fix illegalStateException in drop stats
If a table was created and incremental stats were computed on the table
while events processing is turned off, then after the events processing
is turned on a drop stats or truncate table command on such a table
fails with IllegalStateException. This happens because the
catalog service identifiers are not found in the table properties
while partition for the table are being altered. This patch adds
the catalog service identifiers for drop stats, truncate and comment on
statement code paths to fix the error.
Testing:
1. Added more statements to the test_self_events test to cover the
newly added logic.
2. Manually tested the following scenario which was previously failing
a. starting catalogd without events processing.
b. create partitioned table and compute incremental stats on it.
c. restart catalogd with events processing turned on.
d. issue drop stats command.
Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 27 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/17659/2
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Jul 2021 02:20:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 4: Code-Review+2
Carrying forward Zoltan's +2
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 22:12:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17659/2/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:
http://gerrit.cloudera.org:8080/#/c/17659/2/tests/custom_cluster/test_event_processing.py@693
PS2, Line 693: ]
> flake8: E123 closing bracket does not match indentation of opening bracket'
Done
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 20:09:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7287/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Jul 2021 17:46:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 2: Code-Review+2
LGTM! Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 18:43:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 )
Change subject: IMPALA-10490: Fix illegalStateException in drop stats
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9089/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b4043879370c52049d22acb49c847b0be1c68
Gerrit-Change-Number: 17659
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 18:46:01 +0000
Gerrit-HasComments: No