You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/09/06 18:24:19 UTC

[GitHub] activemq-artemis pull request #2298: ARTEMIS-2065 Change routing-type isnt d...

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2298

    ARTEMIS-2065 Change routing-type isnt destructive.

    Revert previous fix
    Keep original ConfigChangeTest
    Apply new non-destructive fix.
    Enhance tests to ensure messages in queues are not lost either on reload when running or when config changed on-restart (e.g. queue i not destroyed)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2065

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2298
    
----
commit c9d8ad1f38300822a6707cf383bc79fc954114dd
Author: Michael André Pearce <mi...@...>
Date:   2018-09-06T17:41:21Z

    ARTEMIS-2065 Change routing-type isnt destructive.
    
    Revert previous fix
    Keep original ConfigChangeTest
    Apply new non-destructive fix.
    Enhance tests to ensure messages in queues are not lost either on reload when running or when config changed on-restart (e.g. queue i not destroyed)

----


---

[GitHub] activemq-artemis issue #2298: ARTEMIS-2065 Change routing-type isnt destruct...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2298
  
    @jbertram @clebertsuconic here is non-destructive alternative for routing-type change.
    
    I have added extra bits into the test, where a message is sent before the change and the consumed after, to ensure the change is non-destructive. This is added both to the reload config test and also to the config change whilst restart test, to ensure both are non-destructive.
    
    @jbertram i did switch round on the reload test it going from multicast to anycast, this is just because of the queue name used, its easier to make a quick consumer with shared durable via jms to get to the queue named differently to the address. 


---

[GitHub] activemq-artemis pull request #2298: ARTEMIS-2065 Change routing-type isnt d...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2298


---

[GitHub] activemq-artemis issue #2298: ARTEMIS-2065 Change routing-type isnt destruct...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2298
  
    ... still working on this.. there's a failure but I don't know if related... 
    
    I'm keeping it open just for my own control as I'm looking at what's happening.


---

[GitHub] activemq-artemis issue #2298: ARTEMIS-2065 Change routing-type isnt destruct...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2298
  
    let me run my full CI first, and then I will merge this. just to have an idea.


---