You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by GitBox <gi...@apache.org> on 2020/02/15 14:32:01 UTC

[GitHub] [flume] iwasakims opened a new pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.

iwasakims opened a new pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] iwasakims commented on issue #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
iwasakims commented on issue #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316#issuecomment-591293193
 
 
   Thanks, @tmgstevens.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] tmgstevens commented on issue #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
tmgstevens commented on issue #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316#issuecomment-587032644
 
 
   LGTM!
   I'll commit this unless anyone objects?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] tmgstevens commented on a change in pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
tmgstevens commented on a change in pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316#discussion_r379850417
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -116,7 +116,7 @@ limitations under the License.
     <xalan.version>2.7.2</xalan.version>
     <xerces.version>2.9.1</xerces.version>
     <wiremock.version>1.53</wiremock.version>
-    <zookeeper.version>3.4.5</zookeeper.version>
+    <zookeeper.version>3.4.13</zookeeper.version>
 
 Review comment:
   Hi, This looks good to me, but is the Zookeeper uplift necessary for this change? Unless ZK 3.4.13 has something specific we need, I'd be minded to separate that into a different JIRA. Much of the community seems to be lagging on Zookeeper and I'd rather not get out of step.
   Thanks
   Tristan

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] iwasakims commented on a change in pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316#discussion_r379902064
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -116,7 +116,7 @@ limitations under the License.
     <xalan.version>2.7.2</xalan.version>
     <xerces.version>2.9.1</xerces.version>
     <wiremock.version>1.53</wiremock.version>
-    <zookeeper.version>3.4.5</zookeeper.version>
+    <zookeeper.version>3.4.13</zookeeper.version>
 
 Review comment:
   @tmgstevens We need to upgrade ZooKeeper to 3.4.7 at least for Kafka 2.1.0 and above which uses functionality backported on [ZOOKEEPER-2237](https://issues.apache.org/jira/browse/ZOOKEEPER-2237). Unit tests fail with following error if ``zookeeper.version`` is 3.4.5, though there is no compilation error.
   ```
   2020-02-16 12:43:05,908 (main) [ERROR - org.slf4j.helpers.MarkerIgnoringBase.error(MarkerIgnoringBase.java:159)] Fatal error during KafkaServer startup. Prepare to shutdown
   java.lang.NoClassDefFoundError: org/apache/zookeeper/AsyncCallback$MultiCallback
           at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1825)
           at kafka.server.KafkaServer.kafka$server$KafkaServer$$createZkClient$1(KafkaServer.scala:363)
           at kafka.server.KafkaServer.initZkClient(KafkaServer.scala:387)
           at kafka.server.KafkaServer.startup(KafkaServer.scala:207)
           at kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:38)
           at org.apache.flume.source.kafka.KafkaSourceEmbeddedKafka.<init>(KafkaSourceEmbeddedKafka.java:84)
           at org.apache.flume.source.kafka.TestKafkaSource.startKafkaServer(TestKafkaSource.java:112)
           ...(snip)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] tmgstevens commented on a change in pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
tmgstevens commented on a change in pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316#discussion_r380227465
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -116,7 +116,7 @@ limitations under the License.
     <xalan.version>2.7.2</xalan.version>
     <xerces.version>2.9.1</xerces.version>
     <wiremock.version>1.53</wiremock.version>
-    <zookeeper.version>3.4.5</zookeeper.version>
+    <zookeeper.version>3.4.13</zookeeper.version>
 
 Review comment:
   Cool

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] tmgstevens merged pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
tmgstevens merged pull request #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flume] tmgstevens commented on issue #316: FLUME-3355. Upgrade Kafka to 2.3.1.

Posted by GitBox <gi...@apache.org>.
tmgstevens commented on issue #316: FLUME-3355. Upgrade Kafka to 2.3.1.
URL: https://github.com/apache/flume/pull/316#issuecomment-591207271
 
 
   Thanks for your contribution @iwasakims 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services