[GitHub] [airflow] syedahsn commented on issue #31720: Add a log message when a trigger is canceled for timeout

["syedahsn (via GitHub)" <gi...@apache.org>]

syedahsn commented on issue #31720:
URL: https://github.com/apache/airflow/issues/31720#issuecomment-1579203093

   This looks like a really good idea, and I think even the basic option creates a much better user experience. My question is about tracking the number of attempts. Is that inherently something we want to avoid? The current implementation uses both a timer as well as the number of attempts as a metric for determining how long a Trigger should run for. Isn't that better than having just the timer? 
   Also, would it be possible to yield a `TriggerEvent` (with an appropriate message) in the case of a `CancelledError`? That would be the most "natural" way to exit out of the Trigger. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org