[GitHub] [incubator-druid] leventov opened a new issue #7652: Response code for DataSourcesResource on non-existent dataSource or segmentId

[GitBox <gi...@apache.org>]

leventov opened a new issue #7652: Response code for DataSourcesResource on non-existent dataSource or segmentId
URL: https://github.com/apache/incubator-druid/issues/7652
 
 
   #7490 introduced 404 (not found) response in `DataSourcesResource` for non-existent segment ids. As minimum, I think it would be consistent to return 404 instead of 204 (no content) for non-existent segment id for `/{dataSourceName}/segments/{segmentId}` as well.
   
   As maximum, all endpoints in this resources should return 404 on non-existent data source.
   
   There is a [heated discussion on SO](https://stackoverflow.com/q/11746894) regarding whether it's semantically more correct to return 204 or 404 in these situations. To me, it feels that 404 is better.
   
   FYI @dampcake @jon-wei 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org