You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/05 01:05:12 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37002: [SPARK-39616][BUILD][ML] Upgrade Breeze to 2.0

dongjoon-hyun commented on code in PR #37002:
URL: https://github.com/apache/spark/pull/37002#discussion_r913313711


##########
python/run-tests.py:
##########
@@ -96,7 +96,8 @@ def run_individual_python_test(target_dir, test_name, pyspark_python):
     os.mkdir(metastore_dir)
 
     # Also override the JVM's temp directory by setting driver and executor options.
-    java_options = "-Djava.io.tmpdir={0} -Dio.netty.tryReflectionSetAccessible=true".format(tmp_dir)
+    java_options = "-Djava.io.tmpdir={0}".format(tmp_dir)
+    java_options = java_options + " -Dio.netty.tryReflectionSetAccessible=true -Xss16M"

Review Comment:
   Are we using smaller memory in `PySpark` and `SparkR`?
   
   Scala UT seems to use small stack size, `4m`, at large memory like `mx4g`.
   ```
   -Xmx4g -Xss4m -XX:MaxMetaspaceSize=2g
   ```
   
   Although this is already passed, do you think we can use more consistent settings across Scala/Python/R?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org