You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Hans Bakker <ma...@antwebsystems.com> on 2007/08/31 11:26:41 UTC

Re: svn commit: r566181 - in /ofbiz/trunk/applications/order: entitydef/ script/org/ofbiz/order/quote/ script/org/ofbiz/order/request/ src/org/ofbiz/order/order/ src/org/ofbiz/order/shoppingcart/

Hi Sumit,

can you please replace the getCurrentOrderItemWorkEffort class in
orderReadHelper.java with the code below and see if it solves the
problem?

Regards,
Hans


    public String getCurrentOrderItemWorkEffort(GenericValue orderItem)
{
    	String orderItemSeqId = orderItem.getString("orderItemSeqId");
    	String orderId = orderItem.getString("orderId");
    	GenericDelegator delegator = orderItem.getDelegator();
    	GenericValue workOrderItemFulFillment = null;
    	GenericValue workEffort = null;
    	try {
    		List workOrderItemFulFillments =
delegator.findByAndCache("WorkOrderItemFulfillment",
UtilMisc.toMap("orderId", orderId, "orderItemSeqId", orderItemSeqId));
    		if (!UtilValidate.isEmpty(workOrderItemFulFillments)) {
    			workOrderItemFulFillment =
EntityUtil.getFirst(workOrderItemFulFillments);
    			workEffort =
workOrderItemFulFillment.getRelatedOne("WorkEffort");
    		}
    	} catch (GenericEntityException e) {
    		return null;
    	}
    	if (workEffort != null) {
    		return workEffort.getString("workEffortId");
    	} else {
    		return null;
    	}
    }






On Fri, 2007-08-31 at 13:35 +0530, sumit pandit wrote:
> Hi All,
> After rev=566181.
> 
> On 8/15/07, hansbak@apache.org <ha...@apache.org>
> 
> > Author: hansbak
> > Date: Wed Aug 15 07:17:37 2007
> > New Revision: 566181
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=566181
> > Log:
> > OFBIZ 1171, patch from Bilgin Ibryam to allow reservations also on quotes.
> 
> 
> 
> I got error when i edit item of an order.
> I got an exception (nullPointerException)
> the nullPointerException is generated from OrderReadHelper.java when code
> workEffort = workOrderItemFulFillment.getRelatedOne("WorkEffort");  execute
> 
> The stack trace is :-
> 
> 2007-08-31 13:28:29,911 (http-0.0.0.0-8443-Processor4) [
> OrderServices.java:3292:ERROR]
> ---- exception report
> ----------------------------------------------------------
> Exception: org.ofbiz.service.GenericServiceException
> Message: Service target threw an unexpected exception (null)
> ---- stack trace
> ---------------------------------------------------------------
> org.ofbiz.service.GenericServiceException: Service target threw an
> unexpected exception (null)
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(
> StandardJavaEngine.java:103)
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java
> :53)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:335)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:210)
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
> org.ofbiz.order.order.OrderServices.loadCartForUpdate(OrderServices.java
> :3287)
> org.ofbiz.order.order.OrderServices.updateApprovedOrderItems(
> OrderServices.java:3123)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java
> :39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:585)
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(
> StandardJavaEngine.java:91)
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java
> :53)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:335)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:210)
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
> org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java
> :325)
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:448)
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:193)
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:78)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:615)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:269)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:188)
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:215)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:188)
> org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:210)
> org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:174)
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java
> :127)
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java
> :117)
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java
> :108)
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:542)
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
> org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection
> (Http11BaseProtocol.java:665)
> org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(
> PoolTcpEndpoint.java:528)
> org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(
> LeaderFollowerWorkerThread.java:81)
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(
> ThreadPool.java:685)
> java.lang.Thread.run(Thread.java:595)
> java.lang.NullPointerException
> org.ofbiz.order.order.OrderReadHelper.getCurrentOrderItemWorkEffort(
> OrderReadHelper.java:1655)
> org.ofbiz.order.shoppingcart.ShoppingCartServices.loadCartFromOrder(
> ShoppingCartServices.java:322)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java
> :39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:585)
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(
> StandardJavaEngine.java:91)
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java
> :53)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:335)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:210)
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
> org.ofbiz.order.order.OrderServices.loadCartForUpdate(OrderServices.java
> :3287)
> org.ofbiz.order.order.OrderServices.updateApprovedOrderItems(
> OrderServices.java:3123)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java
> :39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:585)
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(
> StandardJavaEngine.java:91)
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java
> :53)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:335)
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:210)
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
> org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java
> :325)
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:448)
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:193)
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:78)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:615)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:269)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:188)
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:215)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:188)
> org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:210)
> org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:174)
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java
> :127)
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java
> :117)
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java
> :108)
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:542)
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
> org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection
> (Http11BaseProtocol.java:665)
> org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(
> PoolTcpEndpoint.java:528)
> org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(
> LeaderFollowerWorkerThread.java:81)
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(
> ThreadPool.java:685)
> java.lang.Thread.run(Thread.java:595)
> --------------------------------------------------------------------------------
> 
> 
-- 
http://Antwebsystems.com : OFBiz Quality support for competitive rates.




Re: svn commit: r566181 - in /ofbiz/trunk/applications/order: entitydef/ script/org/ofbiz/order/quote/ script/org/ofbiz/order/request/ src/org/ofbiz/order/order/ src/org/ofbiz/order/shoppingcart/

Posted by Bilgin Ibryam <bi...@iguanait.com>.
Hi Hans,
yes, your change fixes the bug.
I missed it somehow at that time.Thanks.

Bilgin
-- 
View this message in context: http://www.nabble.com/svn-commit%3A-r566181---in--ofbiz-trunk-applications-order%3A-entitydef--script-org-ofbiz-order-quote--script-org-ofbiz-order-request--src-org-ofbiz-order-order--src-org-ofbiz-order-shoppingcart--tf4273409.html#a12428773
Sent from the OFBiz - Commits mailing list archive at Nabble.com.