[GitHub] [couchdb-documentation] tweenietomatoes commented on a change in pull request #534: new caddy 2 config

[GitBox <gi...@apache.org>]

tweenietomatoes commented on a change in pull request #534:
URL: https://github.com/apache/couchdb-documentation/pull/534#discussion_r420008499



##########
File path: src/best-practices/reverse-proxies.rst
##########
@@ -303,30 +266,6 @@ with headers.
 
 For a better solution, see :ref:`api/auth/proxy`.
 
-SSL/TLS with Caddy
-------------------
-
-Caddy is https-by-default, and will automatically acquire, install, activate and,
-when necessary, renew a trusted SSL certificate for you - all in the background.
-Certificates are issued by the LetsEncrypt certificate authority.
-
-.. code-block:: text
-
-    domain.com {
-
-        import /path/to/other/config.caddy # logging, error handling etc.
-
-        proxy / localhost:5984 {
-            transparent
-            header_upstream x-forwarded-ssl on
-        }
-
-    }
-
-The ``x-forwarded-ssl`` header tells CouchDB that it should use the ``https``

Review comment:
       yes

##########
File path: src/best-practices/reverse-proxies.rst
##########
@@ -193,31 +193,12 @@ requests from ``http(s)://domain.com/...`` to ``http://localhost:5984/...``
 
     domain.com {
 
-        import /path/to/other/config.caddy # logging, error handling etc.
-
-        proxy / localhost:5984 {
-            transparent
-        }
+       reverse_proxy localhost:5984
 
     }
 
-.. Note::
-    The ``transparent`` preset in the ``proxy`` directive is shorthand for:
-
-    .. code-block:: text
-
-        header_upstream Host {host}
-        header_upstream X-Real-IP {remote}
-        header_upstream X-Forwarded-For {remote}
-        header_upstream X-Forwarded-Proto {scheme}

Review comment:
       yes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org