You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 04:33:41 UTC
Re: Review Request 65975: Reconciled storage pools when destroying
volumes with stale profiles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65975/
-----------------------------------------------------------
(Updated June 20, 2018, 4:33 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Added more comments and addressed Benjamin's comment.
Summary (updated)
-----------------
Reconciled storage pools when destroying volumes with stale profiles.
Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825
Repository: mesos
Description (updated)
-------
The storage pools needs to be reconciled in the following two scenarios:
1. When there is a change in the set of known profiles.
2. When a volume/block of a disappeared profile is destroyed, because
the disk space being freed up may belong to another appeared profile.
This patch sequentializes reconciliations triggered by the above two
cases.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
Diff: https://reviews.apache.org/r/65975/diff/6/
Changes: https://reviews.apache.org/r/65975/diff/5-6/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao