You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@camel.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2008/05/24 16:53:54 UTC

[jira] Created: (CAMEL-546) Remove dependency cycle between util and converter

Remove dependency cycle between util and converter
--------------------------------------------------

                 Key: CAMEL-546
                 URL: https://issues.apache.org/activemq/browse/CAMEL-546
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 1.3.0
            Reporter: Christian Schneider
             Fix For: 1.4.0


Currently the packages util and converter reference each other. In the direction from util to converter there is only one reference. ObjectHelper needs ObjectConverter.iterator. As iterator is a static method and does not have anything to do with conversion I think we can move it savely to ObjectHelper. So the cycle disappears. converter uses util but not the other way round. I will add a patch for this.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CAMEL-546) Remove dependency cycle between util and converter

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/CAMEL-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider updated CAMEL-546:
--------------------------------------

    Attachment: objectconverter.patch

This patch moves the iterator method from ObjectConverter to ObjectHelper and changes the classes that use the iterator method.

> Remove dependency cycle between util and converter
> --------------------------------------------------
>
>                 Key: CAMEL-546
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-546
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>             Fix For: 1.4.0
>
>         Attachments: objectconverter.patch
>
>
> Currently the packages util and converter reference each other. In the direction from util to converter there is only one reference. ObjectHelper needs ObjectConverter.iterator. As iterator is a static method and does not have anything to do with conversion I think we can move it savely to ObjectHelper. So the cycle disappears. converter uses util but not the other way round. I will add a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (CAMEL-546) Remove dependency cycle between util and converter

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/CAMEL-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-546.
-------------------------------

    Resolution: Fixed

> Remove dependency cycle between util and converter
> --------------------------------------------------
>
>                 Key: CAMEL-546
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-546
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Claus Ibsen
>             Fix For: 1.4.0
>
>         Attachments: objectconverter.patch
>
>
> Currently the packages util and converter reference each other. In the direction from util to converter there is only one reference. ObjectHelper needs ObjectConverter.iterator. As iterator is a static method and does not have anything to do with conversion I think we can move it savely to ObjectHelper. So the cycle disappears. converter uses util but not the other way round. I will add a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (CAMEL-546) Remove dependency cycle between util and converter

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/CAMEL-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-546:
---------------------------------

    Assignee: Claus Ibsen

> Remove dependency cycle between util and converter
> --------------------------------------------------
>
>                 Key: CAMEL-546
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-546
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Claus Ibsen
>             Fix For: 1.4.0
>
>         Attachments: objectconverter.patch
>
>
> Currently the packages util and converter reference each other. In the direction from util to converter there is only one reference. ObjectHelper needs ObjectConverter.iterator. As iterator is a static method and does not have anything to do with conversion I think we can move it savely to ObjectHelper. So the cycle disappears. converter uses util but not the other way round. I will add a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CAMEL-546) Remove dependency cycle between util and converter

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/CAMEL-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43290#action_43290 ] 

Claus Ibsen commented on CAMEL-546:
-----------------------------------

Hadrian, have committed the patch n the trunk.

We should just mark ObjectConverter.iterate as @deprecated as people should use the ObjectHelper instead.

> Remove dependency cycle between util and converter
> --------------------------------------------------
>
>                 Key: CAMEL-546
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-546
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Claus Ibsen
>             Fix For: 1.4.0
>
>         Attachments: objectconverter.patch
>
>
> Currently the packages util and converter reference each other. In the direction from util to converter there is only one reference. ObjectHelper needs ObjectConverter.iterator. As iterator is a static method and does not have anything to do with conversion I think we can move it savely to ObjectHelper. So the cycle disappears. converter uses util but not the other way round. I will add a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.