You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "trns1997 (via GitHub)" <gi...@apache.org> on 2024/05/22 18:59:35 UTC
[PR] add make export to the ci to check if the archive is correctly exported [nuttx]
trns1997 opened a new pull request, #10534:
URL: https://github.com/apache/nuttx/pull/10534
## Summary
- Test make export archive in the CI
- Add `CONFIG_ARCH_BOARD_COMMON` to all defconfig by default for all boards
Closes #10388
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add make export to the ci to check if the archive is correctly exported [nuttx]
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#discussion_r1610510104
##########
boards/arm/a1x/pcduino-a10/configs/nsh/defconfig:
##########
@@ -46,3 +46,4 @@ CONFIG_START_YEAR=2013
CONFIG_SYMTAB_ORDEREDBYNAME=y
CONFIG_SYSTEM_NSH=y
CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_ARCH_BOARD_COMMON=y
Review Comment:
hey @xiaoxiang781216, i was thinking of addressing this PR finally. I wanted your input regarding this discussing. Do you thins adding `CONFIG_ARCH_BOARD_COMMON=y` to boards that support common folder is acceptable? For now i was thinking of adding it to the STM32 boards and XMC4, or is it generally not a good idea and we want the user to be responsible for setting this option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add make export to the ci to check if the archive is correctly exported [nuttx]
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#issuecomment-3390869000
done in https://github.com/apache/nuttx/pull/17017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10534: add make export to the ci to check if the archive is correctly exported
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#discussion_r1318974716
##########
boards/arm/a1x/pcduino-a10/configs/nsh/defconfig:
##########
@@ -46,3 +46,4 @@ CONFIG_START_YEAR=2013
CONFIG_SYMTAB_ORDEREDBYNAME=y
CONFIG_SYSTEM_NSH=y
CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_ARCH_BOARD_COMMON=y
Review Comment:
not all board support common folder, it is wrong to add CONFIG_ARCH_BOARD_COMMON into ALL defconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on pull request #10534: add make export to the ci to check if the archive is correctly exported
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#issuecomment-1711147394
> > @acassis @xiaoxiang781216 is there a simple way to test the CI locally?
>
> 1. launch the docker used by ci from here:
> https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux
>
> 2. Download nuttx/apps git
>
> 3. run the follow command:
>
>
> ```
> cd nuttx/tools/ci
> ./cibuild.sh -c -A -R testlist/arm-01.dat
> ```
>
> replace arm-01.dat with the test suite you want to run.
I did that but the `fail` variable aways returns 1 is that normal for master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add make export to the ci to check if the archive is correctly exported [nuttx]
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 closed pull request #10534: add make export to the ci to check if the archive is correctly exported
URL: https://github.com/apache/nuttx/pull/10534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on pull request #10534: add make export to the ci to check if the archive is correctly exported
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#issuecomment-1710509391
@acassis @xiaoxiang781216 is there a simple way to test the CI locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add make export to the ci to check if the archive is correctly exported [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#issuecomment-2075485084
@trns1997 are you planing to adding a new PR about this matter?
I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add make export to the ci to check if the archive is correctly exported [nuttx]
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#issuecomment-2075648640
> @trns1997 are you planing to adding a new PR about this matter?
>
> I think it is a good idea to check if "make export" is working, but we need some way to confirm that exported file is working too.
I am not sure, honestly i had forgotten about this PR. We could consider this approach https://github.com/apache/nuttx/issues/10388#issuecomment-1691893627 . Let me know what you think, if you want i can look into it and create a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add make export to the ci to check if the archive is correctly exported [nuttx]
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 closed pull request #10534: add make export to the ci to check if the archive is correctly exported
URL: https://github.com/apache/nuttx/pull/10534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10534: add make export to the ci to check if the archive is correctly exported
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#issuecomment-1710601238
> @acassis @xiaoxiang781216 is there a simple way to test the CI locally?
1. launch the docker used by ci from here:
https://github.com/apache/nuttx/pkgs/container/nuttx%2Fapache-nuttx-ci-linux
2. Download nuttx/apps git
3. run the follow command:
```
cd nuttx/tools/ci
./cibuild.sh -c -A -R testlist/arm-01.dat
```
replace arm-01.dat with the test suite you want to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10534: add make export to the ci to check if the archive is correctly exported
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10534:
URL: https://github.com/apache/nuttx/pull/10534#discussion_r1319427952
##########
boards/arm/a1x/pcduino-a10/configs/nsh/defconfig:
##########
@@ -46,3 +46,4 @@ CONFIG_START_YEAR=2013
CONFIG_SYMTAB_ORDEREDBYNAME=y
CONFIG_SYSTEM_NSH=y
CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_ARCH_BOARD_COMMON=y
Review Comment:
I still need to test, but if we use the exported archive (from make export) to build apps we have the error where it says cannot fine `libboard.a`. I am not sure it is true for all boards though soo I will test have to test that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org