You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by astitcher <gi...@git.apache.org> on 2016/01/19 22:12:11 UTC
[GitHub] qpid-proton pull request: Event tidying
GitHub user astitcher opened a pull request:
https://github.com/apache/qpid-proton/pull/63
Event tidying
Pull request for comment by @alanconway & @cliffjansen
These changes passed the tests on travis and appveyor for me, so hopefully they work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astitcher/qpid-proton event_tidying
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit a30ad539aa89a922ec19e9456fcf2c67fe4daa1e
Author: Andrew Stitcher <as...@apache.org>
Date: 2016-01-18T23:42:58Z
PROTON-1083: [C++ binding] Rearrange handler hierarchy
- User handlers are messaging_handler
- User has no access to lower level proton_handler
x Order of handler processing is subtly different now
-- flow controller gets called after user event handler not before
commit 44049b46c1432c0c341e87df09eb52776ffd2cc5
Author: Andrew Stitcher <as...@apache.org>
Date: 2016-01-19T15:13:07Z
PROTON-1083: Simplified event so that there is no actual hierarchy of events
commit d2337e255713b234eadbe5233eb4f1cf11cfa384
Author: Andrew Stitcher <as...@apache.org>
Date: 2016-01-19T19:50:56Z
PROTON-1083: [C++ binding] Finish completely separating internal/API handlers and events
- There is now no inheritance relationship between proton_handler and messaging_handler
- No inheritance relationship between proton_event and messaging_event/event
- Removed the old handler completely
- Removed a load of dynamic_casts that are now unnecessary
- A bunch of header include tidies up.
commit 90c3a979b233dff623e5c95b504745081121e0bc
Author: Andrew Stitcher <as...@apache.org>
Date: 2016-01-19T20:41:40Z
PROTON-1083: [C++ binding] Renamed messaging_handler as simply handler
- Now the API visible objects are proton::event & proton::handler
commit 711dcd603edebd62300a9d6aa538e3741ca6d3cd
Author: Andrew Stitcher <as...@apache.org>
Date: 2016-01-19T20:58:21Z
NO-JIRA: removed unnecessary declarations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Event tidying
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Event tidying
Posted by cliffjansen <gi...@git.apache.org>.
Github user cliffjansen commented on the pull request:
https://github.com/apache/qpid-proton/pull/63#issuecomment-173235790
Ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Event tidying
Posted by alanconway <gi...@git.apache.org>.
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/63#issuecomment-173013404
Ship it! Neater and cleaner, I rebased my connection_engine branch on it, the only changes I had to make were simpifications to the dispatch loop, everything works. I'll wait for this to go in before I commit the engine stuff.
If you want to look at latest engine see:
https://github.com/alanconway/qpid-proton/tree/cpp-engine-examples
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---