[jira] [Commented] (TAJO-1748) Refine client APIs to throw specific exceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662986#comment-14662986 ] 

ASF GitHub Bot commented on TAJO-1748:
--------------------------------------

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/680

    TAJO-1748: Refine client APIs to throw specific exceptions.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1748

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #680
    
----
commit 874227f26e89f0327e0e54c42a3e0af6da701f1f
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-08-07T13:12:20Z

    Refined catalog APIs' exceptions.

commit 070191e871a0a3d73e093863fd7c3f4b78d32a52
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-08-07T15:49:49Z

    Add unit tests for QueryClient and CatalogAdminClient.

commit e80a72223056086d08e4a10b1f1e85b40128eae2
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-08-08T03:06:49Z

    Cleanup CLI errors.

commit 12052252d6b4b6057ecf2870b0493159025f9969
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-08-08T07:43:14Z

    Improved TajoCli's error handling through client API v1.

commit 0989cd5da73413877c19fe0d01e0d517e6c18ec9
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-08-08T14:05:48Z

    Add error handling to client v2 for failed and killed queries.

----


> Refine client APIs to throw specific exceptions
> -----------------------------------------------
>
>                 Key: TAJO-1748
>                 URL: https://issues.apache.org/jira/browse/TAJO-1748
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Catalog, Java Client
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> This patch includes lots of API changes in terms of only exceptions. In overall, this patch changes throwable exceptions for APIs and unit tests to ensure that the APIs throws exact exceptions. 
> In sum, this patch includes the following changes:
> * Replace CatalogException by TajoException
> * Move almost TajoException/TajoRunException in tajo-core into tajo-common
> * Remove CatalogException and CatalogExceptionUtil
> * Add throwable exception to all APIs in TajoClient, QueryClient, CatalogService, and CatalogAdminClient.
> * Refine all client implementations to throw received exception exactly.
> * Add negative unit tests for all APIs of them
> * Refine Client API v2 to handle exceptional cases like query failed, and killed.
> * Add query fail and kill tests for Client v2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)