[GitHub] [airflow] potiuk commented on a diff in pull request #30718: Add a new arg for KPO to only delete the pod when it doesn't fail

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #30718:
URL: https://github.com/apache/airflow/pull/30718#discussion_r1174446390


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -191,6 +191,8 @@ class KubernetesPodOperator(BaseOperator):
     :param is_delete_operator_pod: What to do when the pod reaches its final
         state, or the execution is interrupted. If True (default), delete the
         pod; if False, leave the pod.
+    :param delete_when_fails: If False, and is_delete_operator_pod is set to True

Review Comment:
   Yep. Agree with @eladkal simple flag is better. I made similar "keep old flag" approaches in the past and it led to really bad complexity/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org