You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "smallyao (via GitHub)" <gi...@apache.org> on 2025/10/10 03:03:08 UTC
[PR] [Improvement]: Remove duplicate keys in web language resource files [amoro]
smallyao opened a new pull request, #3813:
URL: https://github.com/apache/amoro/pull/3813
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3812.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3812] Remove duplicate keys in web language resource files [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 commented on code in PR #3813:
URL: https://github.com/apache/amoro/pull/3813#discussion_r2422334910
##########
amoro-web/src/language/zh.ts:
##########
@@ -21,7 +21,6 @@ export default {
last12h: '最近 12 小时',
last24h: '最近 24 小时',
last7day: '最近 7 天',
- healthScore: '健康度',
Review Comment:
Why don't other Chinese characters have problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3812] Remove duplicate keys in web language resource files [amoro]
Posted by "smallyao (via GitHub)" <gi...@apache.org>.
smallyao commented on PR #3813:
URL: https://github.com/apache/amoro/pull/3813#issuecomment-3408801000
> LGTM.
Thanks for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3812] Remove duplicate keys in web language resource files [amoro]
Posted by "smallyao (via GitHub)" <gi...@apache.org>.
smallyao commented on code in PR #3813:
URL: https://github.com/apache/amoro/pull/3813#discussion_r2422361096
##########
amoro-web/src/language/zh.ts:
##########
@@ -21,7 +21,6 @@ export default {
last12h: '最近 12 小时',
last24h: '最近 24 小时',
last7day: '最近 7 天',
- healthScore: '健康度',
Review Comment:
Thanks for your review.The duplicate key currently flagged during compilation is "healthScore", which appears repeatedly on line 24 and line 230 in the zh.ts/en.ts resource file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3812] Remove duplicate keys in web language resource files [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3813:
URL: https://github.com/apache/amoro/pull/3813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org