You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/05/08 16:48:20 UTC

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Precent slow note, interpreter ...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2324

    [ZEPPELIN-2512] Precent slow note, interpreter search. (master, branch-0.7)

    ### What is this PR for?
    
    Use debounce in search input to avoid the slow search.
    
    See more:
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/25814653/3be8890e-3459-11e7-9be2-6a440ab41861.png)
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2512](https://issues.apache.org/jira/browse/ZEPPELIN-2512)
    
    ### How should this be tested?
    
    1. Create many notes with different names. (50+)
    2. Search using note name filter in home and navbar.
    3. Do the same thing for interpreters in the interpreter page
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2512/add-debounce-for-search-inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2324
    
----
commit 41fef1d13b9564279a7a791f5b030a9ff0548ca4
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:32:55Z

    feat: Add debounce for note name filter

commit 33e0942d516c7d39ad5a4d49753134e28b7e99e0
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:35:38Z

    feat: Add debounce for interpreter search input

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2324: [ZEPPELIN-2512] Prevent slow note, interpreter search....

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2324
  
    @Leemoonsoo Thanks for the review. 
    
    CI failed but irrelevant. 
    
    - https://travis-ci.org/1ambda/zeppelin/jobs/230215694
    
    Found the same errors in 4 different PRs
    
    - https://travis-ci.org/1ambda/zeppelin/jobs/230590633
    - https://travis-ci.org/1ambda/zeppelin/jobs/230549655
    - https://travis-ci.org/1ambda/zeppelin/jobs/230235896
    - https://travis-ci.org/1ambda/zeppelin/jobs/230215694
    
    might be related with https://github.com/apache/zeppelin/pull/2300


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2324: [ZEPPELIN-2512] Prevent slow note, interpreter search....

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2324
  
    Tested and LGTM.
    CI failure looks irrlevant but could you restart failed job? 
    https://travis-ci.org/1ambda/zeppelin/builds/230215692


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2324: [ZEPPELIN-2512] Prevent slow note, interpreter search....

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2324
  
    Merge to master if no further comments!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2324

    [ZEPPELIN-2512] Prevent slow note, interpreter search. (master, branch-0.7)

    ### What is this PR for?
    
    Use debounce in search input to avoid the slow search.
    
    See more:
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/25814653/3be8890e-3459-11e7-9be2-6a440ab41861.png)
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2512](https://issues.apache.org/jira/browse/ZEPPELIN-2512)
    
    ### How should this be tested?
    
    1. Create many notes with different names. (50+)
    2. Search using note name filter in home and navbar.
    3. Do the same thing for interpreters in the interpreter page
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2512/add-debounce-for-search-inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2324
    
----
commit 7a4446e72965c46ea11900c57b3032cc657f9fcb
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:32:55Z

    feat: Add debounce for note name filter

commit 8730614a1c9df622e756b77cbc29f7eda550b85e
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:35:38Z

    feat: Add debounce for interpreter search input

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2324

    [ZEPPELIN-2512] Prevent slow note, interpreter search. (master, branch-0.7)

    ### What is this PR for?
    
    Use debounce in search input to avoid the slow search.
    
    See more:
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/25814653/3be8890e-3459-11e7-9be2-6a440ab41861.png)
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2512](https://issues.apache.org/jira/browse/ZEPPELIN-2512)
    
    ### How should this be tested?
    
    1. Create many notes with different names. (50+)
    2. Search using note name filter in home and navbar.
    3. Do the same thing for interpreters in the interpreter page
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2512/add-debounce-for-search-inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2324
    
----
commit b792ee5c9f6e2bc2793b2a862f0a813d639fd226
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:32:55Z

    feat: Add debounce for note name filter

commit 20292fbf7d8c82246ddf9b25c447913117ff0ade
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:35:38Z

    feat: Add debounce for interpreter search input

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2324: [ZEPPELIN-2512] Prevent slow note, interpreter ...

Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2324

    [ZEPPELIN-2512] Prevent slow note, interpreter search. (master, branch-0.7)

    ### What is this PR for?
    
    Use debounce in search input to avoid the slow search.
    
    See more:
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/25814653/3be8890e-3459-11e7-9be2-6a440ab41861.png)
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2512](https://issues.apache.org/jira/browse/ZEPPELIN-2512)
    
    ### How should this be tested?
    
    1. Create many notes with different names. (50+)
    2. Search using note name filter in home and navbar.
    3. Do the same thing for interpreters in the interpreter page
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2512/add-debounce-for-search-inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2324
    
----
commit 7a4446e72965c46ea11900c57b3032cc657f9fcb
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:32:55Z

    feat: Add debounce for note name filter

commit 8730614a1c9df622e756b77cbc29f7eda550b85e
Author: 1ambda <1a...@gmail.com>
Date:   2017-05-08T16:35:38Z

    feat: Add debounce for interpreter search input

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---