You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/20 10:46:22 UTC

[GitHub] [kylin] zhangayqian opened a new pull request #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

zhangayqian opened a new pull request #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165
 
 
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-601651341
 
 
   ## Pull Request Test Coverage Report for [Build 5778](https://coveralls.io/builds/29498068)
   
   * **2** of **2**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * **3** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.002%**) to **27.522%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/common/SegmentPruner.java](https://coveralls.io/builds/29498068/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcommon%2FSegmentPruner.java#L159) | 1 | 69.23% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29498068/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29498068/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29498068/badge)](https://coveralls.io/builds/29498068) |
   | :-- | --: |
   | Change from base [Build 5776](https://coveralls.io/builds/29463823): |  0.002% |
   | Covered Lines: | 24305 |
   | Relevant Lines: | 88310 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen merged pull request #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] zhangayqian commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
zhangayqian commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-605747464
 
 
   > Hi @zhangayqian would you please add a unit test case in SegmentPrunerTest?
   
   OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-601647642
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=h1) Report
   > Merging [#1165](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/734a997a05bee7b722010b177ec0cce8494bcd1d&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1165/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1165      +/-   ##
   ============================================
   - Coverage     25.06%   25.01%   -0.06%     
   - Complexity     6250     6251       +1     
   ============================================
     Files          1446     1449       +3     
     Lines         88309    88498     +189     
     Branches      12358    12373      +15     
   ============================================
   - Hits          22136    22134       -2     
   - Misses        64003    64185     +182     
   - Partials       2170     2179       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/cube/common/SegmentPruner.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9TZWdtZW50UHJ1bmVyLmphdmE=) | `58.46% <100.00%> (-4.04%)` | `26.00 <3.00> (+1.00)` | :arrow_down: |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `12.91% <0.00%> (-0.42%)` | `6.00% <0.00%> (ø%)` | |
   | [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | `1.53% <0.00%> (-0.04%)` | `2.00% <0.00%> (ø%)` | |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [28 more](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=footer). Last update [734a997...f232282](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
nichunen commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-605621431
 
 
   Hi @zhangayqian would you please add a unit test case in SegmentPrunerTest?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-601647642
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=h1) Report
   > Merging [#1165](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/734a997a05bee7b722010b177ec0cce8494bcd1d&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1165/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1165      +/-   ##
   ============================================
   - Coverage     25.05%   25.05%   -0.01%     
   + Complexity     6249     6247       -2     
   ============================================
     Files          1446     1446              
     Lines         88309    88310       +1     
     Branches      12358    12358              
   ============================================
   - Hits          22128    22126       -2     
   + Misses        64009    64008       -1     
   - Partials       2172     2176       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/cube/common/SegmentPruner.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9TZWdtZW50UHJ1bmVyLmphdmE=) | `56.92% <50.00%> (-5.58%)` | `25.00 <2.00> (ø)` | |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (-0.61%)` | `7.00% <0.00%> (ø%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0.00%> (+2.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `55.68% <0.00%> (+3.40%)` | `8.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=footer). Last update [734a997...2a98e23](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-601651341
 
 
   ## Pull Request Test Coverage Report for [Build 5795](https://coveralls.io/builds/29697846)
   
   * **2** of **2**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * **5** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.0008%**) to **27.476%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/common/SegmentPruner.java](https://coveralls.io/builds/29697846/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcommon%2FSegmentPruner.java#L159) | 1 | 69.23% |
   | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/29697846/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29697846/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29697846/badge)](https://coveralls.io/builds/29697846) |
   | :-- | --: |
   | Change from base [Build 5794](https://coveralls.io/builds/29689586): |  0.0008% |
   | Covered Lines: | 24316 |
   | Relevant Lines: | 88498 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services