You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by pa...@apache.org on 2020/12/10 22:09:36 UTC
[sling-org-apache-sling-feature-cpconverter] branch
issues/SLING-9971 created (now cb6045e)
This is an automated email from the ASF dual-hosted git repository.
pauls pushed a change to branch issues/SLING-9971
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-feature-cpconverter.git.
at cb6045e SLING-9971: AclManagerTest/RepPolicyEntryHandlerTest : no tests for 'deny' entries
This branch includes the following new commits:
new cb6045e SLING-9971: AclManagerTest/RepPolicyEntryHandlerTest : no tests for 'deny' entries
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[sling-org-apache-sling-feature-cpconverter] 01/01: SLING-9971:
AclManagerTest/RepPolicyEntryHandlerTest : no tests for 'deny' entries
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pauls pushed a commit to branch issues/SLING-9971
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-feature-cpconverter.git
commit cb6045eda6fad38330e6c711c5a6e55b53abed7f
Author: Karl Pauls <ka...@gmail.com>
AuthorDate: Thu Dec 10 23:08:56 2020 +0100
SLING-9971: AclManagerTest/RepPolicyEntryHandlerTest : no tests for 'deny' entries
---
.../sling/feature/cpconverter/handlers/RepPolicyEntryHandlerTest.java | 4 ++--
.../handlers/jcr_root/home/users/system/asd/_rep_policy.xml | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/test/java/org/apache/sling/feature/cpconverter/handlers/RepPolicyEntryHandlerTest.java b/src/test/java/org/apache/sling/feature/cpconverter/handlers/RepPolicyEntryHandlerTest.java
index b0ef6b4..f44a527 100644
--- a/src/test/java/org/apache/sling/feature/cpconverter/handlers/RepPolicyEntryHandlerTest.java
+++ b/src/test/java/org/apache/sling/feature/cpconverter/handlers/RepPolicyEntryHandlerTest.java
@@ -174,7 +174,7 @@ public final class RepPolicyEntryHandlerTest {
+ " <rep:restrictions jcr:primaryType=\"rep:Restrictions\" rep:glob=\"{Name}[*/oak:index/*]\"/>" + System.lineSeparator()
+ " </allow0>" + System.lineSeparator()
+ " <allow1 jcr:primaryType=\"rep:GrantACE\" rep:principalName=\"acs-commons-dispatcher-flush-service\" rep:privileges=\"{Name}[jcr:read,crx:replicate,jcr:removeNode]\"/>" + System.lineSeparator()
- +
+ + " <deny0 jcr:primaryType=\"rep:DenyACE\" rep:principalName=\"acs-commons-dispatcher-flush-service\" rep:privileges=\"{Name}[jcr:write]\"/>" + System.lineSeparator() +
"</jcr:root>" + System.lineSeparator();
actual = result.getExcludedAcls();
assertEquals(expected, actual);
@@ -214,7 +214,7 @@ public final class RepPolicyEntryHandlerTest {
+ " <allow3 jcr:primaryType=\"rep:GrantACE\" rep:principalName=\"acs-commons-ensure-service-user-service\" rep:privileges=\"{Name}[jcr:read,rep:write,jcr:readAccessControl,jcr:modifyAccessControl]\"/>" + System.lineSeparator()
+ " <allow4 jcr:primaryType=\"rep:GrantACE\" rep:principalName=\"acs-commons-automatic-package-replicator-service\" rep:privileges=\"{Name}[jcr:read]\"/>" + System.lineSeparator()
+ " <allow5 jcr:primaryType=\"rep:GrantACE\" rep:principalName=\"acs-commons-on-deploy-scripts-service\" rep:privileges=\"{Name}[jcr:read]\"/>" + System.lineSeparator()
- +
+ + " <deny0 jcr:primaryType=\"rep:DenyACE\" rep:principalName=\"acs-commons-dispatcher-flush-service\" rep:privileges=\"{Name}[jcr:write]\"/>" + System.lineSeparator() +
"</jcr:root>" + System.lineSeparator();
actual = result.getExcludedAcls();
assertEquals(expected, actual);
diff --git a/src/test/resources/org/apache/sling/feature/cpconverter/handlers/jcr_root/home/users/system/asd/_rep_policy.xml b/src/test/resources/org/apache/sling/feature/cpconverter/handlers/jcr_root/home/users/system/asd/_rep_policy.xml
index 66bb45c..b265e03 100644
--- a/src/test/resources/org/apache/sling/feature/cpconverter/handlers/jcr_root/home/users/system/asd/_rep_policy.xml
+++ b/src/test/resources/org/apache/sling/feature/cpconverter/handlers/jcr_root/home/users/system/asd/_rep_policy.xml
@@ -45,4 +45,8 @@
jcr:primaryType="rep:GrantACE"
rep:principalName="acs-commons-on-deploy-scripts-service"
rep:privileges="{Name}[jcr:read]"/>
+ <deny0
+ jcr:primaryType="rep:DenyACE"
+ rep:principalName="acs-commons-dispatcher-flush-service"
+ rep:privileges="{Name}[jcr:write]"/>
</jcr:root>