You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/02/02 19:39:23 UTC
Review Request 30511: Moved framework related rate limiters into
Master::Frameworks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jiang Yan Xu.
Bugs: MESOS-1148
https://issues.apache.org/jira/browse/MESOS-1148
Repository: mesos
Description
-------
In the subsequent review a slave related rate limiter is added. So moved the framework related rate limiters inside 'frameworks'.
No functional changes.
Diffs
-----
src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30
src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
Diff: https://reviews.apache.org/r/30511/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 30511: Moved framework related rate limiters into
Master::Frameworks.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/#review70601
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Feb. 2, 2015, 10:39 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30511/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 10:39 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jiang Yan Xu.
>
>
> Bugs: MESOS-1148
> https://issues.apache.org/jira/browse/MESOS-1148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the subsequent review a slave related rate limiter is added. So moved the framework related rate limiters inside 'frameworks'.
>
> No functional changes.
>
>
> Diffs
> -----
>
> src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30
> src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
>
> Diff: https://reviews.apache.org/r/30511/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 30511: Moved framework related rate limiters into
Master::Frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 12:30 a.m.)
Review request for mesos, Ben Mahler and Jiang Yan Xu.
Changes
-------
rebased. NNFR.
Bugs: MESOS-1148
https://issues.apache.org/jira/browse/MESOS-1148
Repository: mesos
Description
-------
In the subsequent review a slave related rate limiter is added. So moved the framework related rate limiters inside 'frameworks'.
No functional changes.
Diffs (updated)
-----
src/master/master.hpp cd37ee9d3c57bcd91f08cd402ec1e4a09d9e42ee
src/master/master.cpp d04b2c4041d8fe8978b877f07579a6f907903e1b
Diff: https://reviews.apache.org/r/30511/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 30511: Moved framework related rate limiters into
Master::Frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 6:28 p.m.)
Review request for mesos, Ben Mahler and Jiang Yan Xu.
Changes
-------
benm's. NNFR.
Bugs: MESOS-1148
https://issues.apache.org/jira/browse/MESOS-1148
Repository: mesos
Description
-------
In the subsequent review a slave related rate limiter is added. So moved the framework related rate limiters inside 'frameworks'.
No functional changes.
Diffs (updated)
-----
src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30
src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
Diff: https://reviews.apache.org/r/30511/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 30511: Moved framework related rate limiters into
Master::Frameworks.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Feb. 2, 2015, 6:10 p.m., Ben Mahler wrote:
> > I recall Yan and I discussed improving the BoundedRateLimiter abstraction to provide a interface that returns failed futures when the bound is reached, but I don't think we documented it or the implications of such a change.
> >
> > Mind adding a small TODO for this?
It's documented here: https://issues.apache.org/jira/browse/MESOS-1723 but unfortunately not in the code.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/#review70695
-----------------------------------------------------------
On Feb. 2, 2015, 10:39 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30511/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 10:39 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jiang Yan Xu.
>
>
> Bugs: MESOS-1148
> https://issues.apache.org/jira/browse/MESOS-1148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the subsequent review a slave related rate limiter is added. So moved the framework related rate limiters inside 'frameworks'.
>
> No functional changes.
>
>
> Diffs
> -----
>
> src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30
> src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
>
> Diff: https://reviews.apache.org/r/30511/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 30511: Moved framework related rate limiters into
Master::Frameworks.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/#review70695
-----------------------------------------------------------
Ship it!
I recall Yan and I discussed improving the BoundedRateLimiter abstraction to provide a interface that returns failed futures when the bound is reached, but I don't think we documented it or the implications of such a change.
Mind adding a small TODO for this?
src/master/master.hpp
<https://reviews.apache.org/r/30511/#comment116043>
Any reason to nest this in the Framework struct? Seems like a more general abstraction. We could hide it in the master.cpp since you should be able to forward declare here?
Then we can have a TODO on BoundedRateLimiter to provide a cleaner abstraction (i.e. provide an `aquire` that fails a future when capacity is exceeded, if possible. I believe there are some subtleties there IIRC).
src/master/master.cpp
<https://reviews.apache.org/r/30511/#comment116042>
Hm.. mind indenting this to show that it's a continuation of the < operation for the last line?
- Ben Mahler
On Feb. 2, 2015, 6:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30511/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 6:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jiang Yan Xu.
>
>
> Bugs: MESOS-1148
> https://issues.apache.org/jira/browse/MESOS-1148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the subsequent review a slave related rate limiter is added. So moved the framework related rate limiters inside 'frameworks'.
>
> No functional changes.
>
>
> Diffs
> -----
>
> src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30
> src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
>
> Diff: https://reviews.apache.org/r/30511/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>