You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/29 15:08:42 UTC

[GitHub] [incubator-superset] sturmer commented on issue #5791: Improve code quality based on LGTM.com feedback

sturmer commented on issue #5791: Improve code quality based on LGTM.com feedback
URL: https://github.com/apache/incubator-superset/issues/5791#issuecomment-478033006
 
 
   Hey there,
   
   I'm looking into this. (Just saying in the hope to avoid duplicate efforts.)
   
   I see that LGTM flags 5 errors but, 58 warnings and 61 recommendations. Do we want all of them in the same PR, or maybe we can split it (first errors, then warnings, then recommendations) and have smaller PRs?
   
   Best,
   Gianluca

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org