You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Werner Punz <we...@gmx.at> on 2007/02/06 12:12:58 UTC

Question regarding adding a new verification task

Hi
Since I am currently working on fixing a lot of missing references in
the sandbox Taglib classes.
(Some people including me used a lot of includes from entities resulting
in several missing attribute implementations)

I am going to write, since this seems to be the most obvious way,
a program which checks the generated component tlds via introspection
against the taglib classes for those references.

If anyone is willing, to integrate it into maven once I am done
please drop a note here.

Otherwise is there maybe already a check in maven which does this test?
Tomcat is unable to check it as it seems, although I turned on
tldValidation it did not report errors which were there.
Also most other app server skip it, but weblogic does not
and it is correct that it does not skip it.



Re: Question regarding adding a new verification task

Posted by Dennis Byrne <de...@dbyrne.net>.
Oops, I meant this.

http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/AbstractTagLibTestCase.java?revision=491515&view=markup

Dennis Byrne

On 2/6/07, Dennis Byrne <de...@dbyrne.net> wrote:
>
> You may want to let this do the work for you.
>
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
>
>
> Dennis Byrne
>
> On 2/6/07, Werner Punz <we...@gmx.at> wrote:
> >
> > Hi
> > Since I am currently working on fixing a lot of missing references in
> > the sandbox Taglib classes.
> > (Some people including me used a lot of includes from entities resulting
> > in several missing attribute implementations)
> >
> > I am going to write, since this seems to be the most obvious way,
> > a program which checks the generated component tlds via introspection
> > against the taglib classes for those references.
> >
> > If anyone is willing, to integrate it into maven once I am done
> > please drop a note here.
> >
> > Otherwise is there maybe already a check in maven which does this test?
> > Tomcat is unable to check it as it seems, although I turned on
> > tldValidation it did not report errors which were there.
> > Also most other app server skip it, but weblogic does not
> > and it is correct that it does not skip it.
> >
> >
> >
>
>
> --
> Dennis Byrne




-- 
Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Matthias Wessendorf <ma...@apache.org>.
I bet ;)

On 2/7/07, Cagatay Civici <ca...@gmail.com> wrote:
> > Which ASs do this BTW?
> >
>
>  I'm not sure but it may be weblogic.
>
>  Cagatay
>
>
> On 2/7/07, Dennis Byrne <de...@dbyrne.net> wrote:
> > You want to have a test to that would fail for non String class TLD
> attributes?  It may be a good idea for us in terms of interoperability.
> Which ASs do this BTW?
> >
> > Dennis Byrne
> >
> >
> >
> > On 2/6/07, Werner Punz <we...@gmail.com> wrote:
> > > Btw. speaking of unit tests, I am not fully familiar with the specs in
> > > this area, but some app servers choke on non class String definitions in
> > > the tld attributes.
> > > There is no test case for that at least in the sandbox, I am not
> > > sure if there is one for Tomahawk.
> > >
> > > Any ideas, if I just missed it?
> > >
> > >
> > >
> > > Dennis Byrne schrieb:
> > > > Hi Werner,
> > > >
> > > > Glad to help. Please take the time to vote for getting this feature
> into
> > > > the Shale test framework.
> > > >
> > > > https://issues.apache.org/struts/browse/SHALE-382
> > > > < https://issues.apache.org/struts/browse/SHALE-382>
> > > >
> > > > Dennis Byrne
> > > >
> > > > On 2/6/07, *Werner Punz* < werner.punz@gmail.com
> > > > <mailto: werner.punz@gmail.com>> wrote:
> > > >
> > > >     Ok guys, especially Dennis and Martin
> > > >     thanks to you I finally
> > > >     could nail down
> > > >     and fix or mark the missing
> > > >     attributes.
> > > >     The sandbox now should work in way more containers than it used
> > > >     to (commit follows in a few minutes)
> > > >
> > > >     Werner
> > > >
> > > >
> > > >
> > > >     Werner Punz schrieb:
> > > >     > Thanks a lot Dennis this was exactly what
> > > >     > I was looking for!
> > > >     >
> > > >     >
> > > >     >
> > > >     > Dennis Byrne schrieb:
> > > >     >> You may want to let this do the work for you.
> > > >     >>
> > > >     >>
> > > >
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> > > >     <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >
> > > >     >>
> > > >     <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> > > >     <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >>
> > > >     >>
> > > >     >> Dennis Byrne
> > > >     >>
> > > >     >> On 2/6/07, *Werner Punz* < werpu@gmx.at <mailto: werpu@gmx.at>
> > > >     <mailto:werpu@gmx.at <mailto: werpu@gmx.at>>> wrote:
> > > >     >>
> > > >     >>     Hi
> > > >     >>     Since I am currently working on fixing a lot of missing
> > > >     references in
> > > >     >>     the sandbox Taglib classes.
> > > >     >>     (Some people including me used a lot of includes from
> > > >     entities resulting
> > > >     >>     in several missing attribute implementations)
> > > >     >>
> > > >     >>     I am going to write, since this seems to be the most
> obvious way,
> > > >     >>     a program which checks the generated component tlds via
> > > >     introspection
> > > >     >>     against the taglib classes for those references.
> > > >     >>
> > > >     >>     If anyone is willing, to integrate it into maven once I am
> done
> > > >     >>     please drop a note here.
> > > >     >>
> > > >     >>     Otherwise is there maybe already a check in maven which
> does
> > > >     this test?
> > > >     >>     Tomcat is unable to check it as it seems, although I turned
> on
> > > >     >>     tldValidation it did not report errors which were there.
> > > >     >>     Also most other app server skip it, but weblogic does not
> > > >     >>     and it is correct that it does not skip it.
> > > >     >>
> > > >     >>
> > > >     >>
> > > >     >>
> > > >     >>
> > > >     >> --
> > > >     >> Dennis Byrne
> > > >     >
> > > >     >
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Dennis Byrne
> > >
> > >
> >
> >
> >
> > --
> > Dennis Byrne
>
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: Question regarding adding a new verification task

Posted by Cagatay Civici <ca...@gmail.com>.
>
> Which ASs do this BTW?
>

I'm not sure but it may be weblogic.

Cagatay

On 2/7/07, Dennis Byrne <de...@dbyrne.net> wrote:
>
> You want to have a test to that would fail for non String class TLD
> attributes?  It may be a good idea for us in terms of interoperability.
> Which ASs do this BTW?
>
> Dennis Byrne
>
> On 2/6/07, Werner Punz <we...@gmail.com> wrote:
> >
> > Btw. speaking of unit tests, I am not fully familiar with the specs in
> > this area, but some app servers choke on non class String definitions in
> > the tld attributes.
> > There is no test case for that at least in the sandbox, I am not
> > sure if there is one for Tomahawk.
> >
> > Any ideas, if I just missed it?
> >
> >
> >
> > Dennis Byrne schrieb:
> > > Hi Werner,
> > >
> > > Glad to help. Please take the time to vote for getting this feature
> > into
> > > the Shale test framework.
> > >
> > > https://issues.apache.org/struts/browse/SHALE-382
> > > < https://issues.apache.org/struts/browse/SHALE-382>
> > >
> > > Dennis Byrne
> > >
> > > On 2/6/07, *Werner Punz* <werner.punz@gmail.com
> > > <mailto: werner.punz@gmail.com>> wrote:
> > >
> > >     Ok guys, especially Dennis and Martin
> > >     thanks to you I finally
> > >     could nail down
> > >     and fix or mark the missing
> > >     attributes.
> > >     The sandbox now should work in way more containers than it used
> > >     to (commit follows in a few minutes)
> > >
> > >     Werner
> > >
> > >
> > >
> > >     Werner Punz schrieb:
> > >     > Thanks a lot Dennis this was exactly what
> > >     > I was looking for!
> > >     >
> > >     >
> > >     >
> > >     > Dennis Byrne schrieb:
> > >     >> You may want to let this do the work for you.
> > >     >>
> > >     >>
> > >     http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >
> > >     <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> > >
> > >     >>
> > >     <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >
> > >     <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> > >>
> > >     >>
> > >     >> Dennis Byrne
> > >     >>
> > >     >> On 2/6/07, *Werner Punz* <werpu@gmx.at <mailto: werpu@gmx.at>
> > >     <mailto:werpu@gmx.at <ma...@gmx.at>>> wrote:
> > >     >>
> > >     >>     Hi
> > >     >>     Since I am currently working on fixing a lot of missing
> > >     references in
> > >     >>     the sandbox Taglib classes.
> > >     >>     (Some people including me used a lot of includes from
> > >     entities resulting
> > >     >>     in several missing attribute implementations)
> > >     >>
> > >     >>     I am going to write, since this seems to be the most
> > obvious way,
> > >     >>     a program which checks the generated component tlds via
> > >     introspection
> > >     >>     against the taglib classes for those references.
> > >     >>
> > >     >>     If anyone is willing, to integrate it into maven once I am
> > done
> > >     >>     please drop a note here.
> > >     >>
> > >     >>     Otherwise is there maybe already a check in maven which
> > does
> > >     this test?
> > >     >>     Tomcat is unable to check it as it seems, although I turned
> > on
> > >     >>     tldValidation it did not report errors which were there.
> > >     >>     Also most other app server skip it, but weblogic does not
> > >     >>     and it is correct that it does not skip it.
> > >     >>
> > >     >>
> > >     >>
> > >     >>
> > >     >>
> > >     >> --
> > >     >> Dennis Byrne
> > >     >
> > >     >
> > >
> > >
> > >
> > >
> > > --
> > > Dennis Byrne
> >
> >
>
>
> --
> Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Werner Punz <we...@gmail.com>.
Dennis Byrne schrieb:
> You want to have a test to that would fail for non String class TLD
> attributes?  It may be a good idea for us in terms of interoperability. 
> Which ASs do this BTW?
> 
Weblogic, I stumbled over it and over the non linked attributes
because of a user report in a users list.
I have been working for the past few weeks with the user testing on this
to get tomahawk and the sandbox up and running in weblogic.


Re: Question regarding adding a new verification task

Posted by Dennis Byrne <de...@dbyrne.net>.
You want to have a test to that would fail for non String class TLD
attributes?  It may be a good idea for us in terms of interoperability.
Which ASs do this BTW?

Dennis Byrne

On 2/6/07, Werner Punz <we...@gmail.com> wrote:
>
> Btw. speaking of unit tests, I am not fully familiar with the specs in
> this area, but some app servers choke on non class String definitions in
> the tld attributes.
> There is no test case for that at least in the sandbox, I am not
> sure if there is one for Tomahawk.
>
> Any ideas, if I just missed it?
>
>
>
> Dennis Byrne schrieb:
> > Hi Werner,
> >
> > Glad to help. Please take the time to vote for getting this feature into
> > the Shale test framework.
> >
> > https://issues.apache.org/struts/browse/SHALE-382
> > <https://issues.apache.org/struts/browse/SHALE-382>
> >
> > Dennis Byrne
> >
> > On 2/6/07, *Werner Punz* <werner.punz@gmail.com
> > <ma...@gmail.com>> wrote:
> >
> >     Ok guys, especially Dennis and Martin
> >     thanks to you I finally
> >     could nail down
> >     and fix or mark the missing
> >     attributes.
> >     The sandbox now should work in way more containers than it used
> >     to (commit follows in a few minutes)
> >
> >     Werner
> >
> >
> >
> >     Werner Punz schrieb:
> >     > Thanks a lot Dennis this was exactly what
> >     > I was looking for!
> >     >
> >     >
> >     >
> >     > Dennis Byrne schrieb:
> >     >> You may want to let this do the work for you.
> >     >>
> >     >>
> >
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >     <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >
> >     >>
> >     <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >     <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >>
> >     >>
> >     >> Dennis Byrne
> >     >>
> >     >> On 2/6/07, *Werner Punz* <werpu@gmx.at <ma...@gmx.at>
> >     <mailto:werpu@gmx.at <ma...@gmx.at>>> wrote:
> >     >>
> >     >>     Hi
> >     >>     Since I am currently working on fixing a lot of missing
> >     references in
> >     >>     the sandbox Taglib classes.
> >     >>     (Some people including me used a lot of includes from
> >     entities resulting
> >     >>     in several missing attribute implementations)
> >     >>
> >     >>     I am going to write, since this seems to be the most obvious
> way,
> >     >>     a program which checks the generated component tlds via
> >     introspection
> >     >>     against the taglib classes for those references.
> >     >>
> >     >>     If anyone is willing, to integrate it into maven once I am
> done
> >     >>     please drop a note here.
> >     >>
> >     >>     Otherwise is there maybe already a check in maven which does
> >     this test?
> >     >>     Tomcat is unable to check it as it seems, although I turned
> on
> >     >>     tldValidation it did not report errors which were there.
> >     >>     Also most other app server skip it, but weblogic does not
> >     >>     and it is correct that it does not skip it.
> >     >>
> >     >>
> >     >>
> >     >>
> >     >>
> >     >> --
> >     >> Dennis Byrne
> >     >
> >     >
> >
> >
> >
> >
> > --
> > Dennis Byrne
>
>


-- 
Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Werner Punz <we...@gmail.com>.
Btw. speaking of unit tests, I am not fully familiar with the specs in
this area, but some app servers choke on non class String definitions in
the tld attributes.
There is no test case for that at least in the sandbox, I am not
sure if there is one for Tomahawk.

Any ideas, if I just missed it?



Dennis Byrne schrieb:
> Hi Werner,
> 
> Glad to help. Please take the time to vote for getting this feature into
> the Shale test framework.
> 
> https://issues.apache.org/struts/browse/SHALE-382
> <https://issues.apache.org/struts/browse/SHALE-382>
> 
> Dennis Byrne
> 
> On 2/6/07, *Werner Punz* <werner.punz@gmail.com
> <ma...@gmail.com>> wrote:
> 
>     Ok guys, especially Dennis and Martin
>     thanks to you I finally
>     could nail down
>     and fix or mark the missing
>     attributes.
>     The sandbox now should work in way more containers than it used
>     to (commit follows in a few minutes)
> 
>     Werner
> 
> 
> 
>     Werner Punz schrieb:
>     > Thanks a lot Dennis this was exactly what
>     > I was looking for!
>     >
>     >
>     >
>     > Dennis Byrne schrieb:
>     >> You may want to let this do the work for you.
>     >>
>     >>
>     http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
>     <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log>
>     >>
>     <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
>     <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log>>
>     >>
>     >> Dennis Byrne
>     >>
>     >> On 2/6/07, *Werner Punz* <werpu@gmx.at <ma...@gmx.at>
>     <mailto:werpu@gmx.at <ma...@gmx.at>>> wrote:
>     >>
>     >>     Hi
>     >>     Since I am currently working on fixing a lot of missing
>     references in
>     >>     the sandbox Taglib classes.
>     >>     (Some people including me used a lot of includes from
>     entities resulting
>     >>     in several missing attribute implementations)
>     >>
>     >>     I am going to write, since this seems to be the most obvious way,
>     >>     a program which checks the generated component tlds via
>     introspection
>     >>     against the taglib classes for those references.
>     >>
>     >>     If anyone is willing, to integrate it into maven once I am done
>     >>     please drop a note here.
>     >>
>     >>     Otherwise is there maybe already a check in maven which does
>     this test?
>     >>     Tomcat is unable to check it as it seems, although I turned on
>     >>     tldValidation it did not report errors which were there.
>     >>     Also most other app server skip it, but weblogic does not
>     >>     and it is correct that it does not skip it.
>     >>
>     >>
>     >>
>     >>
>     >>
>     >> --
>     >> Dennis Byrne
>     >
>     >
> 
> 
> 
> 
> -- 
> Dennis Byrne


Re: Question regarding adding a new verification task

Posted by Dennis Byrne <de...@dbyrne.net>.
Hi Werner,

Glad to help. Please take the time to vote for getting this feature into the
Shale test framework.

https://issues.apache.org/struts/browse/SHALE-382

Dennis Byrne

On 2/6/07, Werner Punz <we...@gmail.com> wrote:
>
> Ok guys, especially Dennis and Martin
> thanks to you I finally
> could nail down
> and fix or mark the missing
> attributes.
> The sandbox now should work in way more containers than it used
> to (commit follows in a few minutes)
>
> Werner
>
>
>
> Werner Punz schrieb:
> > Thanks a lot Dennis this was exactly what
> > I was looking for!
> >
> >
> >
> > Dennis Byrne schrieb:
> >> You may want to let this do the work for you.
> >>
> >>
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >> <
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> >
> >>
> >> Dennis Byrne
> >>
> >> On 2/6/07, *Werner Punz* <werpu@gmx.at <ma...@gmx.at>> wrote:
> >>
> >>     Hi
> >>     Since I am currently working on fixing a lot of missing references
> in
> >>     the sandbox Taglib classes.
> >>     (Some people including me used a lot of includes from entities
> resulting
> >>     in several missing attribute implementations)
> >>
> >>     I am going to write, since this seems to be the most obvious way,
> >>     a program which checks the generated component tlds via
> introspection
> >>     against the taglib classes for those references.
> >>
> >>     If anyone is willing, to integrate it into maven once I am done
> >>     please drop a note here.
> >>
> >>     Otherwise is there maybe already a check in maven which does this
> test?
> >>     Tomcat is unable to check it as it seems, although I turned on
> >>     tldValidation it did not report errors which were there.
> >>     Also most other app server skip it, but weblogic does not
> >>     and it is correct that it does not skip it.
> >>
> >>
> >>
> >>
> >>
> >> --
> >> Dennis Byrne
> >
> >
>
>


-- 
Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Werner Punz <we...@gmail.com>.
Ok guys, especially Dennis and Martin
thanks to you I finally
could nail down
and fix or mark the missing
attributes.
The sandbox now should work in way more containers than it used
to (commit follows in a few minutes)

Werner



Werner Punz schrieb:
> Thanks a lot Dennis this was exactly what
> I was looking for!
> 
> 
> 
> Dennis Byrne schrieb:
>> You may want to let this do the work for you.
>>
>> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
>> <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log>
>>
>> Dennis Byrne
>>
>> On 2/6/07, *Werner Punz* <werpu@gmx.at <ma...@gmx.at>> wrote:
>>
>>     Hi
>>     Since I am currently working on fixing a lot of missing references in
>>     the sandbox Taglib classes.
>>     (Some people including me used a lot of includes from entities resulting
>>     in several missing attribute implementations)
>>
>>     I am going to write, since this seems to be the most obvious way,
>>     a program which checks the generated component tlds via introspection
>>     against the taglib classes for those references.
>>
>>     If anyone is willing, to integrate it into maven once I am done
>>     please drop a note here.
>>
>>     Otherwise is there maybe already a check in maven which does this test?
>>     Tomcat is unable to check it as it seems, although I turned on
>>     tldValidation it did not report errors which were there.
>>     Also most other app server skip it, but weblogic does not
>>     and it is correct that it does not skip it.
>>
>>
>>
>>
>>
>> -- 
>> Dennis Byrne
> 
> 


Re: Question regarding adding a new verification task

Posted by Werner Punz <we...@gmail.com>.
Thanks a lot Dennis this was exactly what
I was looking for!



Dennis Byrne schrieb:
> You may want to let this do the work for you.
> 
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log
> <http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log>
> 
> Dennis Byrne
> 
> On 2/6/07, *Werner Punz* <werpu@gmx.at <ma...@gmx.at>> wrote:
> 
>     Hi
>     Since I am currently working on fixing a lot of missing references in
>     the sandbox Taglib classes.
>     (Some people including me used a lot of includes from entities resulting
>     in several missing attribute implementations)
> 
>     I am going to write, since this seems to be the most obvious way,
>     a program which checks the generated component tlds via introspection
>     against the taglib classes for those references.
> 
>     If anyone is willing, to integrate it into maven once I am done
>     please drop a note here.
> 
>     Otherwise is there maybe already a check in maven which does this test?
>     Tomcat is unable to check it as it seems, although I turned on
>     tldValidation it did not report errors which were there.
>     Also most other app server skip it, but weblogic does not
>     and it is correct that it does not skip it.
> 
> 
> 
> 
> 
> -- 
> Dennis Byrne


Re: Question regarding adding a new verification task

Posted by Dennis Byrne <de...@dbyrne.net>.
You may want to let this do the work for you.

http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log

Dennis Byrne

On 2/6/07, Werner Punz <we...@gmx.at> wrote:
>
> Hi
> Since I am currently working on fixing a lot of missing references in
> the sandbox Taglib classes.
> (Some people including me used a lot of includes from entities resulting
> in several missing attribute implementations)
>
> I am going to write, since this seems to be the most obvious way,
> a program which checks the generated component tlds via introspection
> against the taglib classes for those references.
>
> If anyone is willing, to integrate it into maven once I am done
> please drop a note here.
>
> Otherwise is there maybe already a check in maven which does this test?
> Tomcat is unable to check it as it seems, although I turned on
> tldValidation it did not report errors which were there.
> Also most other app server skip it, but weblogic does not
> and it is correct that it does not skip it.
>
>
>


-- 
Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Dennis Byrne <de...@dbyrne.net>.
You may want to let this do the work for you.

http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log

Dennis Byrne


On 2/6/07, Martin Marinschek <ma...@gmail.com> wrote:
>
> There was someone who wrote an automatic test to check for this - I
> don't remember who and when that was, though. Can you have a look into
> the test directories and check? Maybe you can extend one of the
> test-classes instead of writing a new utility?
>
> regards,
>
> Martin
>
> On 2/6/07, Werner Punz <we...@gmx.at> wrote:
> > Hi
> > Since I am currently working on fixing a lot of missing references in
> > the sandbox Taglib classes.
> > (Some people including me used a lot of includes from entities resulting
> > in several missing attribute implementations)
> >
> > I am going to write, since this seems to be the most obvious way,
> > a program which checks the generated component tlds via introspection
> > against the taglib classes for those references.
> >
> > If anyone is willing, to integrate it into maven once I am done
> > please drop a note here.
> >
> > Otherwise is there maybe already a check in maven which does this test?
> > Tomcat is unable to check it as it seems, although I turned on
> > tldValidation it did not report errors which were there.
> > Also most other app server skip it, but weblogic does not
> > and it is correct that it does not skip it.
> >
> >
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>



-- 
Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Paul Spencer <pa...@apache.org>.
IMHO Tomahawk should NOT require the sandbox tld passes the test, thus
1) do not uncomment the line
2) do remove the TODO
3) Configure tomahawk's maven to create at test jar
4) Configure sandbox's maven to use tomahawk's test jar.
5) Create an sandbox test that extends AbstractTagLibTestCase

Please wait until after the 1.1.5 release to do this!

Paul Spencer

[1]http://maven.apache.org/guides/mini/guide-attached-tests.html

Dennis Byrne wrote:
> When it came time to commit it, including the sandbox wasn't realistic.
> There were a lot of failures.
> 
> Dennis Byrne
> 
> On 2/6/07, Paul Spencer <pa...@apache.org> wrote:
>>
>> I believe this is what Martin is referring to the Tomahawk test
>> MyFacesTagLibTestCase[1].
>>
>> BTW: It looks like the verification of the sandbox taglibs was commented
>>   out.
>>
>>
>> Paul Spencer
>>
>>
>> [1]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/MyFacesTagLibTestCase.java?view=markup 
>>
>>
>> Martin Marinschek wrote:
>> > There was someone who wrote an automatic test to check for this - I
>> > don't remember who and when that was, though. Can you have a look into
>> > the test directories and check? Maybe you can extend one of the
>> > test-classes instead of writing a new utility?
>> >
>> > regards,
>> >
>> > Martin
>> >
>> > On 2/6/07, Werner Punz <we...@gmx.at> wrote:
>> >> Hi
>> >> Since I am currently working on fixing a lot of missing references in
>> >> the sandbox Taglib classes.
>> >> (Some people including me used a lot of includes from entities
>> resulting
>> >> in several missing attribute implementations)
>> >>
>> >> I am going to write, since this seems to be the most obvious way,
>> >> a program which checks the generated component tlds via introspection
>> >> against the taglib classes for those references.
>> >>
>> >> If anyone is willing, to integrate it into maven once I am done
>> >> please drop a note here.
>> >>
>> >> Otherwise is there maybe already a check in maven which does this 
>> test?
>> >> Tomcat is unable to check it as it seems, although I turned on
>> >> tldValidation it did not report errors which were there.
>> >> Also most other app server skip it, but weblogic does not
>> >> and it is correct that it does not skip it.
>> >>
>> >>
>> >>
>> >
>> >
>>
>>
> 
> 


Re: Question regarding adding a new verification task

Posted by Dennis Byrne <de...@dbyrne.net>.
When it came time to commit it, including the sandbox wasn't realistic.
There were a lot of failures.

Dennis Byrne

On 2/6/07, Paul Spencer <pa...@apache.org> wrote:
>
> I believe this is what Martin is referring to the Tomahawk test
> MyFacesTagLibTestCase[1].
>
> BTW: It looks like the verification of the sandbox taglibs was commented
>   out.
>
>
> Paul Spencer
>
>
> [1]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/MyFacesTagLibTestCase.java?view=markup
>
> Martin Marinschek wrote:
> > There was someone who wrote an automatic test to check for this - I
> > don't remember who and when that was, though. Can you have a look into
> > the test directories and check? Maybe you can extend one of the
> > test-classes instead of writing a new utility?
> >
> > regards,
> >
> > Martin
> >
> > On 2/6/07, Werner Punz <we...@gmx.at> wrote:
> >> Hi
> >> Since I am currently working on fixing a lot of missing references in
> >> the sandbox Taglib classes.
> >> (Some people including me used a lot of includes from entities
> resulting
> >> in several missing attribute implementations)
> >>
> >> I am going to write, since this seems to be the most obvious way,
> >> a program which checks the generated component tlds via introspection
> >> against the taglib classes for those references.
> >>
> >> If anyone is willing, to integrate it into maven once I am done
> >> please drop a note here.
> >>
> >> Otherwise is there maybe already a check in maven which does this test?
> >> Tomcat is unable to check it as it seems, although I turned on
> >> tldValidation it did not report errors which were there.
> >> Also most other app server skip it, but weblogic does not
> >> and it is correct that it does not skip it.
> >>
> >>
> >>
> >
> >
>
>


-- 
Dennis Byrne

Re: Question regarding adding a new verification task

Posted by Paul Spencer <pa...@apache.org>.
I believe this is what Martin is referring to the Tomahawk test 
MyFacesTagLibTestCase[1].

BTW: It looks like the verification of the sandbox taglibs was commented 
  out.


Paul Spencer

[1]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/MyFacesTagLibTestCase.java?view=markup

Martin Marinschek wrote:
> There was someone who wrote an automatic test to check for this - I
> don't remember who and when that was, though. Can you have a look into
> the test directories and check? Maybe you can extend one of the
> test-classes instead of writing a new utility?
> 
> regards,
> 
> Martin
> 
> On 2/6/07, Werner Punz <we...@gmx.at> wrote:
>> Hi
>> Since I am currently working on fixing a lot of missing references in
>> the sandbox Taglib classes.
>> (Some people including me used a lot of includes from entities resulting
>> in several missing attribute implementations)
>>
>> I am going to write, since this seems to be the most obvious way,
>> a program which checks the generated component tlds via introspection
>> against the taglib classes for those references.
>>
>> If anyone is willing, to integrate it into maven once I am done
>> please drop a note here.
>>
>> Otherwise is there maybe already a check in maven which does this test?
>> Tomcat is unable to check it as it seems, although I turned on
>> tldValidation it did not report errors which were there.
>> Also most other app server skip it, but weblogic does not
>> and it is correct that it does not skip it.
>>
>>
>>
> 
> 


Re: Question regarding adding a new verification task

Posted by Martin Marinschek <ma...@gmail.com>.
There was someone who wrote an automatic test to check for this - I
don't remember who and when that was, though. Can you have a look into
the test directories and check? Maybe you can extend one of the
test-classes instead of writing a new utility?

regards,

Martin

On 2/6/07, Werner Punz <we...@gmx.at> wrote:
> Hi
> Since I am currently working on fixing a lot of missing references in
> the sandbox Taglib classes.
> (Some people including me used a lot of includes from entities resulting
> in several missing attribute implementations)
>
> I am going to write, since this seems to be the most obvious way,
> a program which checks the generated component tlds via introspection
> against the taglib classes for those references.
>
> If anyone is willing, to integrate it into maven once I am done
> please drop a note here.
>
> Otherwise is there maybe already a check in maven which does this test?
> Tomcat is unable to check it as it seems, although I turned on
> tldValidation it did not report errors which were there.
> Also most other app server skip it, but weblogic does not
> and it is correct that it does not skip it.
>
>
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces