[jira] Commented: (HARMONY-738) [classlib][nio] Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest

["Andrew Zhang (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-738?page=comments#action_12419198 ] 

Andrew Zhang commented on HARMONY-738:
--------------------------------------

Hello George,

The fix looks good, thank you very much!

Best regards,
Andrew

> [classlib][nio] Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest
> --------------------------------------------------------------------------------------------
>
>          Key: HARMONY-738
>          URL: http://issues.apache.org/jira/browse/HARMONY-738
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest. 
> They are test_read_$LByteBuffer(), test_read_$LByteBufferII(). 
> Following code doesn't ensure all data are read in blocking mode:
> 	do {
> 	    long count = source.read(readBufArray, 0, 2);
> 	    if (count < 0) {
> 	         break;
> 	    }
> 	    totalCount += count;
> 	} while (totalCount != 10 && !isBlocking);
> Also, sink.close() should be invoked to ensure that all data are sent.
> I'll upload a patch soon.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira