You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/02 06:10:06 UTC

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #415: [FLINK-30269] Validate table name for metadata table

zjureel commented on code in PR #415:
URL: https://github.com/apache/flink-table-store/pull/415#discussion_r1037815747


##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/FlinkCatalog.java:
##########
@@ -190,6 +191,12 @@ public void createTable(ObjectPath tablePath, CatalogBaseTable table, boolean ig
             throw new UnsupportedOperationException(
                     "Only support CatalogTable, but is: " + table.getClass());
         }
+        if (tablePath.getObjectName().contains(METADATA_TABLE_SPLITTER)) {

Review Comment:
   Nice, I think `AbstractCatalog.getTableLocation` is better 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org