[GitHub] [accumulo] EdColeman commented on a diff in pull request #3787: Clean up Thrift SSL code

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3787:
URL: https://github.com/apache/accumulo/pull/3787#discussion_r1340710570


##########
core/src/main/java/org/apache/accumulo/core/rpc/SslConnectionParams.java:
##########
@@ -222,26 +222,12 @@ public String getTrustStoreType() {
     return trustStoreType;
   }
 
-  // Work around THRIFT-3450 ... fixed with b9641e094...
-  static class TSSLTransportParametersHack extends TSSLTransportParameters {
-    TSSLTransportParametersHack(String clientProtocol) {
-      super(clientProtocol, new String[] {});
-      this.cipherSuites = null;
-    }
-  }
-
-  public TSSLTransportParameters getTTransportParams() {
+  public TSSLTransportParameters getTSSLTransportParameters() {
     if (useJsse) {
-      throw new IllegalStateException("Cannot get TTransportParams for JSEE configuration.");
-    }
-
-    TSSLTransportParameters params;
-    if (cipherSuites != null) {
-      params = new TSSLTransportParameters(clientProtocol, cipherSuites);
-    } else {
-      params = new TSSLTransportParametersHack(clientProtocol);
+      throw new IllegalStateException("Cannot get TTransportParams for JSSE configuration.");

Review Comment:
   ```suggestion
         throw new IllegalStateException("Cannot get TSSLTransportParameters for JSSE configuration.");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org