Re: [PR] EXPERIMENT: [C++] Always prefer mimalloc to jemalloc [arrow]

["austin3dickey (via GitHub)" <gi...@apache.org>]

austin3dickey commented on PR #40875:
URL: https://github.com/apache/arrow/pull/40875#issuecomment-2045981353

   >Ok, it's not obvious if this actually changed anything in the benchmarking setup
   
   I'm not exactly sure either. Before my recent changes, we had set ARROW_MIMALLOC=ON and ARROW_JEMALLOC=OFF in the environment:
   
   https://github.com/apache/arrow/blob/dbedcfce79f221e9217ec34725668a686c6d4478/dev/conbench_envs/benchmarks.env#L30
   
   [ARROW_JEMALLOC=OFF](https://github.com/voltrondata-labs/arrow-benchmarks-ci/blob/09364cdb53f6b1ab191565ee3281f55350bc832b/buildkite/benchmark/utils.sh#L26)
   
   But we weren't necessarily picking up the environment variables during the archery build. I think both might have been OFF during cmake.
   
   I recently made a series of PRs so we know we're picking up those environment variables for the build we're using for benchmarks:
   - https://github.com/voltrondata-labs/benchmarks/pull/159
   - https://github.com/voltrondata-labs/arrow-benchmarks-ci/pull/184
   - https://github.com/apache/arrow/pull/40925
   
   That last PR has yet to be merged but I'm running the final benchmark tests on it now. Those should definitely be running with mimalloc, not jemalloc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org