[GitHub] [airflow] dstandish commented on pull request #29452: Add support of a different AWS connection for DynamoDB

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on PR #29452:
URL: https://github.com/apache/airflow/pull/29452#issuecomment-1426099946

   I would like to suggest that you add "s3_conn_id" instead of "dynamodb_conn_id".    Otherwise this end up with quite unintuitive behavior IMO.
   
   Because when user sees "dynamodb_conn_id" they will likely assume that's the one they should use.  So then I expect that commonly a user will inadvertently do transfer between dynamodb, connection ID and AWS connection ID.
   
   But if, on the other hand, you add S3 con ID, then user can leave that None generally speaking, and the AWS conn_id will always be the one thats used for Dynamo db.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org