You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/11/21 01:01:09 UTC
[GitHub] [trafficcontrol] rob05c commented on a change in pull request
#4136: Block server type update when server is assigned DSes
rob05c commented on a change in pull request #4136: Block server type update when server is assigned DSes
URL: https://github.com/apache/trafficcontrol/pull/4136#discussion_r348851544
##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -36,7 +39,7 @@ import (
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
- "github.com/go-ozzo/ozzo-validation"
+ validation "github.com/go-ozzo/ozzo-validation"
Review comment:
+1 on removing the alias. Yeah, we have a bunch of places that do it, I'm guessing whoever added the library first didn't realize Go follows the package name, not the directory; and everyone else just copied it. If it's an idiom, IMO it's an antipattern and we should remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services