[GitHub] [pinot] ankitsultana commented on a diff in pull request #9873: [Draft] [multistage] PoC for Shuffle Skip Algorithm

[GitBox <gi...@apache.org>]

ankitsultana commented on code in PR #9873:
URL: https://github.com/apache/pinot/pull/9873#discussion_r1035642443


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -98,6 +98,10 @@ protected List<Object[]> queryRunner(String sql) {
   protected List<Object[]> queryH2(String sql)
       throws Exception {
     Statement h2statement = _h2Connection.createStatement(ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
+    // TODO: Hack. Let's discuss how best to support this.
+    if (sql.contains("option")) {
+      sql = sql.replaceAll("option\\(useColocatedJoin\\=true\\)", "");

Review Comment:
   I added this to ensure basic sanity tests are passing. Proper tests for colocated join would be quite complex and I don't know if we have a ready to use framework.
   
   I can undo this change and pick up the tests in a separate PR since they'll take time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org