You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/04/17 15:47:05 UTC
[PR] GH-41258: [C#][Integration] Fix comparison of sliced validity buffers with non-zero offsets [arrow]
paleolimbot opened a new pull request, #41259:
URL: https://github.com/apache/arrow/pull/41259
### Rationale for this change
After https://github.com/apache/arrow/pull/41230 , the integration tests are failing on main .
### What changes are included in this PR?
The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.
### Are these changes tested?
Via the integration test CI job.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41258: [C#][Integration] Fix comparison of sliced validity buffers with non-zero offsets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41259:
URL: https://github.com/apache/arrow/pull/41259#issuecomment-2061615632
:warning: GitHub issue #41258 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41258: [C#][Integration] Fix comparison of sliced validity buffers with non-zero offsets [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #41259:
URL: https://github.com/apache/arrow/pull/41259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41258: [C#][Integration] Fix comparison of sliced validity buffers with non-zero offsets [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41259:
URL: https://github.com/apache/arrow/pull/41259#issuecomment-2063587519
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 73386cb806a429875f1846b69e21beccfd339b21.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23972061021) has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org