[jira] [Commented] (DRILL-6081) Duration of completed queries is continuously increasing

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322510#comment-16322510 ] 

ASF GitHub Bot commented on DRILL-6081:
---------------------------------------

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/1088

    DRILL-6081: Set query end time before writing final profile

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-6081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1088.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1088
    
----
commit e60baf9dc194853090173c13ac959f40b938032a
Author: Arina Ielchiieva <ar...@...>
Date:   2018-01-11T15:40:04Z

    DRILL-6081: Set query end time before writing final profile

----


> Duration of completed queries is continuously increasing
> --------------------------------------------------------
>
>                 Key: DRILL-6081
>                 URL: https://issues.apache.org/jira/browse/DRILL-6081
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.13.0
>            Reporter: Anton Gozhiy
>            Assignee: Arina Ielchiieva
>             Fix For: 1.13.0
>
>
> Steps:
> 1. Execute some query (for example "select * from sys.version")
> 2. Go to the profiles page: http://node1:8047/profiles
> 3. Open the details page for the query
> 4. Expand the duration section
> Expected result:
> The duration should be adequate and shouldn't be changed after the page reload
> Actual result:
> The duration is continuously increasing (You should reload page to notice that)
> ||Planning||Queued||Execution||Total||
> |0.092 sec|0.012 sec|59 min 36.487 sec	|59 min 36.591 sec|
> Workaround: none
> Note:
> The issue introduced after the following fix:
> https://issues.apache.org/jira/browse/DRILL-5963
> *ROOT CAUSE*
> After refactoring made in DRILL-5963 making query start / queue / end time was moved to another abstraction {{queryStateProcessor}}. On Foreman close {{queryStateProcessor}} was closed after final query profile was stored thus query end time was never updated. To fix this issue we need to close {{queryStateProcessor}} before writing query final profile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)